Skip to content

Commit 432096d

Browse files
ducalexducalex
committed
Renamed RG_SCREEN_BGR to RG_SCREEN_RGB_BGR
1 parent 3f47089 commit 432096d

File tree

16 files changed

+18
-16
lines changed

16 files changed

+18
-16
lines changed

‎components/retro-go/drivers/display/ili9341.h‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -235,10 +235,10 @@ static void lcd_init(void)
235235
ILI9341_CMD(0x01); // Reset
236236
rg_usleep(5 * 1000); // Wait 5ms after reset
237237
ILI9341_CMD(0x3A, 0X55); // COLMOD (Pixel Format Set RGB565 65k)
238-
#if defined(RG_SCREEN_ROTATION) && defined(RG_SCREEN_BGR)
238+
#if defined(RG_SCREEN_ROTATION) && defined(RG_SCREEN_RGB_BGR)
239239
// The rotation is designed so that the user can simply try all values 0-7 to find what works.
240240
// It's simpler than trying to explain the MADCTL register bits, combined with hardware variations...
241-
ILI9341_CMD(0x36, (RG_SCREEN_BGR ? 0x08 : 0x00) | (RG_SCREEN_ROTATION << 5)); // MADCTL (0x08=BGR, 0x20=MV, 0x40=MX, 0x80=MY)
241+
ILI9341_CMD(0x36, (RG_SCREEN_RGB_BGR ? 0x08 : 0x00) | (RG_SCREEN_ROTATION << 5)); // MADCTL (0x08=BGR, 0x20=MV, 0x40=MX, 0x80=MY)
242242
#endif
243243
#ifdef RG_SCREEN_INIT
244244
RG_SCREEN_INIT();

‎components/retro-go/rg_gui.c‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -681,6 +681,8 @@ void rg_gui_draw_dialog(const char *title, const rg_gui_option_t *options, size_
681681
int col2_width = -1;
682682
uint8_t row_height[options_count];
683683

684+
// FIXME: The information built in this loop should be cached between calls to rg_gui_draw_dialog...
685+
// It doesn't matter for most dialogs but the file picker with 500+ files wastes a LOT of time here.
684686
for (size_t i = 0; i < options_count; i++)
685687
{
686688
if (options[i].flags == RG_DIALOG_FLAG_HIDDEN)

‎components/retro-go/targets/byteboi-rev1/config.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
#define RG_SCREEN_WIDTH 320
2626
#define RG_SCREEN_HEIGHT 240
2727
#define RG_SCREEN_ROTATION 5 // Possible values are 0-7 (you'll have to experiment)
28-
#define RG_SCREEN_BGR 1 // Possible values are 0-1 (change if colors are bad)
28+
#define RG_SCREEN_RGB_BGR 1 // Possible values are 0-1 (change if colors are bad)
2929
#define RG_SCREEN_VISIBLE_AREA {0, 0, 0, 0}
3030
#define RG_SCREEN_SAFE_AREA {0, 0, 0, 0}
3131
#define RG_SCREEN_INIT() \

‎components/retro-go/targets/crokpocket/config.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
#define RG_SCREEN_WIDTH 320
2222
#define RG_SCREEN_HEIGHT 240
2323
#define RG_SCREEN_ROTATION 0 // Possible values are 0-7 (you'll have to experiment)
24-
#define RG_SCREEN_BGR 1 // Possible values are 0-1 (change if colors are bad)
24+
#define RG_SCREEN_RGB_BGR 1 // Possible values are 0-1 (change if colors are bad)
2525
#define RG_SCREEN_VISIBLE_AREA {0, 0, 0, 0} // Left, Top, Right, Bottom
2626
#define RG_SCREEN_SAFE_AREA {0, 0, 0, 0} // Left, Top, Right, Bottom
2727

‎components/retro-go/targets/esp32-p4/config.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@
6969
#define RG_SCREEN_WIDTH 320
7070
#define RG_SCREEN_HEIGHT 240
7171
#define RG_SCREEN_ROTATION 0 // Possible values are 0-7 (you'll have to experiment)
72-
#define RG_SCREEN_BGR 1 // Possible values are 0-1 (change if colors are bad)
72+
#define RG_SCREEN_RGB_BGR 1 // Possible values are 0-1 (change if colors are bad)
7373
#define RG_SCREEN_VISIBLE_AREA {0, 0, 0, 0} // Left, Top, Right, Bottom
7474
#define RG_SCREEN_SAFE_AREA {0, 0, 0, 0} // Left, Top, Right, Bottom
7575
#define RG_SCREEN_PARTIAL_UPDATES 1

‎components/retro-go/targets/esplay-micro/config.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
#define RG_SCREEN_WIDTH 320
2626
#define RG_SCREEN_HEIGHT 240
2727
#define RG_SCREEN_ROTATION 1 // Possible values are 0-7 (you'll have to experiment)
28-
#define RG_SCREEN_BGR 1 // Possible values are 0-1 (change if colors are bad)
28+
#define RG_SCREEN_RGB_BGR 1 // Possible values are 0-1 (change if colors are bad)
2929
#define RG_SCREEN_VISIBLE_AREA {0, 0, 0, 0}
3030
#define RG_SCREEN_SAFE_AREA {0, 0, 0, 0}
3131
#define RG_SCREEN_INIT() \

‎components/retro-go/targets/fri3d-2024/config.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
#define RG_SCREEN_WIDTH 296
2929
#define RG_SCREEN_HEIGHT 240
3030
#define RG_SCREEN_ROTATION 1 // Possible values are 0-7 (you'll have to experiment)
31-
#define RG_SCREEN_BGR 1 // Possible values are 0-1 (change if colors are bad)
31+
#define RG_SCREEN_RGB_BGR 1 // Possible values are 0-1 (change if colors are bad)
3232
#define RG_SCREEN_VISIBLE_AREA {0, 0, 0, 0} // Left, Top, Right, Bottom
3333
#define RG_SCREEN_SAFE_AREA {0, 0, 0, 0} // Left, Top, Right, Bottom
3434
#define RG_SCREEN_INIT() \

‎components/retro-go/targets/mrgc-g32/config.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@
6565
#define RG_SCREEN_WIDTH 240
6666
#define RG_SCREEN_HEIGHT 320
6767
#define RG_SCREEN_ROTATION 0 // Possible values are 0-7 (you'll have to experiment)
68-
#define RG_SCREEN_BGR 0 // Possible values are 0-1 (change if colors are bad)
68+
#define RG_SCREEN_RGB_BGR 0 // Possible values are 0-1 (change if colors are bad)
6969
#define RG_SCREEN_VISIBLE_AREA {0, 28, 0, 68} // left, top, right, bottom
7070
#define RG_SCREEN_SAFE_AREA {0, 0, 0, 0} // left, top, right, bottom
7171
#define RG_SCREEN_PARTIAL_UPDATES 1

‎components/retro-go/targets/mrgc-gbm/config.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
#define RG_SCREEN_WIDTH 240
2626
#define RG_SCREEN_HEIGHT 240
2727
#define RG_SCREEN_ROTATION 0 // Possible values are 0-7 (you'll have to experiment)
28-
#define RG_SCREEN_BGR 0 // Possible values are 0-1 (change if colors are bad)
28+
#define RG_SCREEN_RGB_BGR 0 // Possible values are 0-1 (change if colors are bad)
2929
#define RG_SCREEN_VISIBLE_AREA {0, 38, 0, 10} /* Fullscreen for plastic case. Black bar on bottom for metal case. */
3030
// #define RG_SCREEN_VISIBLE_AREA {0, 38, 0, 0} /* Fullscreen for metal case. Cropped on bottom for plastic case. */
3131
#define RG_SCREEN_SAFE_AREA {0, 0, 0, 0}

‎components/retro-go/targets/nullnano/config.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
#define RG_SCREEN_WIDTH 300
2222
#define RG_SCREEN_HEIGHT 240
2323
#define RG_SCREEN_ROTATION 0 // Possible values are 0-7 (you'll have to experiment)
24-
#define RG_SCREEN_BGR 1 // Possible values are 0-1 (change if colors are bad)
24+
#define RG_SCREEN_RGB_BGR 1 // Possible values are 0-1 (change if colors are bad)
2525
#define RG_SCREEN_VISIBLE_AREA {20, 0, 0, 0} // Left, Top, Right, Bottom
2626
#define RG_SCREEN_SAFE_AREA {20, 0, 20, 0} // Left, Top, Right, Bottom
2727
#define RG_SCREEN_INIT() \

0 commit comments

Comments
 (0)