rg_storage: Do not log ENOENT errors

They're polluting the logs and entirely expected.

The other solution to prevent this spam is to call rg_storage_exists() all the time, but it will slow down accesses quite a bit due to walking the FAT twice...

Author: ducalex

components/retro-go/rg_storage.c

@@ -357,12 +357,17 @@ bool rg_storage_scandir(const char *path, rg_scandir_cb_t *callback, void *arg,
 
     DIR *dir = opendir(path);
     if (!dir)
+    {
+        if (errno != ENOENT) // Only log unusual errors. Path not found isn't unusual.
+            RG_LOGE("Opendir failed (%d): '%s'", errno, path);
         return false;
+    }
 
     // We allocate on heap in case we go recursive through rg_storage_delete
     rg_scandir_t *result = calloc(1, sizeof(rg_scandir_t));
     if (!result)
     {
+        RG_LOGE("Memory allocation failed: '%s'", path);
         closedir(dir);
         return false;
     }
@@ -456,7 +461,8 @@ bool rg_storage_read_file(const char *path, void **data_out, size_t *data_len, u
     FILE *fp = fopen(path, "rb");
     if (!fp)
     {
-        RG_LOGE("Fopen failed (%d): '%s'", errno, path);
+        if (errno != ENOENT) // Only log unusual errors. Path not found isn't unusual.
+            RG_LOGE("Fopen failed (%d): '%s'", errno, path);
         return false;
     }
 
@@ -574,7 +580,8 @@ bool rg_storage_unzip_file(const char *zip_path, const char *filter, void **data
     FILE *fp = fopen(zip_path, "rb");
     if (!fp)
     {
-        RG_LOGE("Fopen failed (%d): '%s'", errno, zip_path);
+        if (errno != ENOENT) // Only log unusual errors. Path not found isn't unusual.
+            RG_LOGE("Fopen failed (%d): '%s'", errno, zip_path);
         return false;
     }
 

components/retro-go/rg_surface.c

@@ -314,6 +314,7 @@ rg_surface_t *rg_surface_load_image_file(const char *filename, uint32_t flags)
         return img;
     }
 
+    // RG_LOGE("Image loading failed: '%s'", filename);
     return NULL;
 }
 

launcher/main/gui.c

@@ -631,7 +631,7 @@ void gui_load_preview(tab_t *tab)
 
     if (!tab->preview && file->checksum && (show_missing_cover || errors))
     {
-        RG_LOGI("No image found for '%s'\n", file->name);
+        RG_LOGD("No image found for '%s'\n", file->name);
         gui_set_status(tab, NULL, errors ? "Bad cover" : "No cover");
         // gui_draw_status(tab);
         // tab->preview = gui_get_image("cover", file->app);