fix: resolve golangci-lint errcheck and unconvert violations

- Remove redundant uint32 cast in vector_getters.go (unconvert)
- Wrap defer Close() calls in require.NoError for errcheck compliance
  in enum_bench_test.go (conn, dkRows, Stmt) and types_test.go (rows x2)

Author: hellower

enum_bench_test.go

@@ -4,12 +4,14 @@ import (
 	"context"
 	"database/sql"
 	"database/sql/driver"
+	"errors"
 	"fmt"
 	"io"
 	"testing"
 
-	"github.com/duckdb/duckdb-go/v2/mapping"
 	"github.com/stretchr/testify/require"
+
+	"github.com/duckdb/duckdb-go/v2/mapping"
 )
 
 // getEnumCGO is the original (pre-optimization) implementation, preserved
@@ -79,7 +81,9 @@ func benchEnumVector(b *testing.B, rowCount int, useCGO bool) {
 	mc, err := c.Connect(context.Background())
 	require.NoError(b, err)
 	conn := mc.(*Conn)
-	defer conn.Close()
+	defer func() {
+		require.NoError(b, conn.Close())
+	}()
 
 	var sink string
 	b.ResetTimer()
@@ -98,7 +102,7 @@ func benchEnumVector(b *testing.B, rowCount int, useCGO bool) {
 
 		for {
 			e = r.Next(dest)
-			if e == io.EOF {
+			if errors.Is(e, io.EOF) {
 				break
 			}
 			require.NoError(b, e)
@@ -114,8 +118,8 @@ func benchEnumVector(b *testing.B, rowCount int, useCGO bool) {
 			count++
 		}
 
-		dkRows.Close()
-		s.Close()
+		require.NoError(b, dkRows.Close())
+		require.NoError(b, s.Close())
 		require.Equal(b, rowCount, count)
 	}
 

types_test.go

@@ -790,7 +790,9 @@ func TestEnumNullValues(t *testing.T) {
 
 	rows, err := db.Query("SELECT val FROM nullable_colors ORDER BY rowid")
 	require.NoError(t, err)
-	defer rows.Close()
+	defer func() {
+		require.NoError(t, rows.Close())
+	}()
 
 	expected := []any{"red", nil, "blue"}
 	for _, exp := range expected {
@@ -827,7 +829,9 @@ func TestEnumLargeDictionary(t *testing.T) {
 
 	rows, err := db.Query("SELECT val FROM large_enum_tbl ORDER BY rowid")
 	require.NoError(t, err)
-	defer rows.Close()
+	defer func() {
+		require.NoError(t, rows.Close())
+	}()
 
 	expected := []string{"v0", "v255", "v299"}
 	for _, exp := range expected {

vector_getters.go

@@ -209,7 +209,7 @@ func (vec *vector) getEnum(rowIdx mapping.IdxT) string {
 	case TYPE_USMALLINT:
 		idx = uint32(getPrimitive[uint16](vec, rowIdx))
 	case TYPE_UINTEGER:
-		idx = uint32(getPrimitive[uint32](vec, rowIdx))
+		idx = getPrimitive[uint32](vec, rowIdx)
 	case TYPE_UBIGINT:
 		idx = uint32(getPrimitive[uint64](vec, rowIdx))
 	}