Skip to content

Commit bba3300

Browse files
authored
Merge pull request #118 from samansmink/fix-etag-issue
fix: etag checking bug
2 parents 4135c19 + 7bcaf1f commit bba3300

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

extension/httpfs/httpfs.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,7 @@ unique_ptr<HTTPResponse> HTTPFileSystem::GetRangeRequest(FileHandle &handle, str
232232
if (static_cast<int>(response.status) < 300) { // done redirecting
233233
out_offset = 0;
234234

235-
if (!hfh.http_params.unsafe_disable_etag_checks && hfh.etag.empty() && response.HasHeader("ETag")) {
235+
if (!hfh.http_params.unsafe_disable_etag_checks && !hfh.etag.empty() && response.HasHeader("ETag")) {
236236
string responseEtag = response.GetHeaderValue("ETag");
237237

238238
if (!responseEtag.empty() && responseEtag != hfh.etag) {

0 commit comments

Comments
 (0)