Skip to content

Commit be31632

Browse files
authored
Merge pull request #57 from samansmink/set-secret-type
set secret type extension
2 parents c0f4eb5 + 73b0bdc commit be31632

File tree

2 files changed

+19
-0
lines changed

2 files changed

+19
-0
lines changed

extension/httpfs/create_secret_functions.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -211,6 +211,7 @@ void CreateS3SecretFunctions::RegisterCreateSecretFunction(DatabaseInstance &ins
211211
secret_type.name = type;
212212
secret_type.deserializer = KeyValueSecret::Deserialize<KeyValueSecret>;
213213
secret_type.default_provider = "config";
214+
secret_type.extension = "httpfs";
214215

215216
ExtensionUtil::RegisterSecretType(instance, secret_type);
216217

@@ -225,6 +226,7 @@ void CreateBearerTokenFunctions::Register(DatabaseInstance &instance) {
225226
secret_type_hf.name = HUGGINGFACE_TYPE;
226227
secret_type_hf.deserializer = KeyValueSecret::Deserialize<KeyValueSecret>;
227228
secret_type_hf.default_provider = "config";
229+
secret_type_hf.extension = "httpfs";
228230
ExtensionUtil::RegisterSecretType(instance, secret_type_hf);
229231

230232
// Huggingface config provider
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
# name: test/sql/secret/test_secret_type.test
2+
# description: Test the secret types added by this extension
3+
# group: [httpfs]
4+
5+
require httpfs
6+
7+
statement ok
8+
PRAGMA enable_verification
9+
10+
query II
11+
SELECT type, default_provider from duckdb_secret_types() where extension='httpfs' order by type;
12+
----
13+
aws config
14+
gcs config
15+
huggingface config
16+
r2 config
17+
s3 config

0 commit comments

Comments
 (0)