fix: http 206 not considered success

Author: samansmink

extension/httpfs/httpfs.cpp

@@ -344,8 +344,8 @@ bool HTTPFileSystem::TryRangeRequest(FileHandle &handle, string url, HTTPHeaders
 	auto res = GetRangeRequest(handle, url, header_map, file_offset, buffer_out, buffer_out_len);
 
 	if (res) {
-		// Request succeeded
-		if (res->Success()) {
+		// Request succeeded TODO: fix upstream that 206 is not considered success
+		if (res->Success() || res->status == HTTPStatusCode::PartialContent_206 || res->status == HTTPStatusCode::Accepted_202) {
 			return true;
 		}
 

test/sql/secret/secret_aws.test

@@ -14,6 +14,8 @@ require-env DUCKDB_S3_ENDPOINT
 
 require-env DUCKDB_S3_USE_SSL
 
+set ignore_error_messages
+
 require httpfs
 
 require parquet

test/sql/secret/secret_refresh.test

@@ -14,6 +14,8 @@ require-env DUCKDB_S3_ENDPOINT
 
 require-env DUCKDB_S3_USE_SSL
 
+set ignore_error_messages
+
 require httpfs
 
 require parquet

test/sql/secret/secret_refresh_attach.test

@@ -16,6 +16,8 @@ require-env DUCKDB_S3_USE_SSL
 
 require-env S3_ATTACH_DB
 
+set ignore_error_messages
+
 require httpfs
 
 require parquet