Merge pull request #290 from michaelwallabi/mbecke/fix-quoting

Fix quotedIdentifier and quotedString

Author: jraymakers

api/src/sql.ts

@@ -1,7 +1,7 @@
 export function quotedString(input: string): string {
-  return `'${input.replace(`'`, `''`)}'`;
+  return `'${input.replaceAll(`'`, `''`)}'`;
 }
 
 export function quotedIdentifier(input: string): string {
-  return `"${input.replace(`"`, `""`)}"`;
+  return `"${input.replaceAll(`"`, `""`)}"`;
 }

api/test/api.test.ts

@@ -105,6 +105,8 @@ import {
   intervalValue,
   listValue,
   mapValue,
+  quotedIdentifier,
+  quotedString,
   structValue,
   timeTZValue,
   timeValue,
@@ -2402,4 +2404,45 @@ ORDER BY name
       });
     });
   });
+
+  describe('SQL utility functions', () => {
+    test('quotedString', () => {
+      // Basic string
+      assert.equal(quotedString('hello'), "'hello'");
+
+      // String with single quotes
+      assert.equal(quotedString("it's"), "'it''s'");
+      assert.equal(quotedString("'quoted'"), "'''quoted'''");
+
+      // String with multiple single quotes
+      assert.equal(quotedString("it's 'really' good"), "'it''s ''really'' good'");
+
+      // Empty string
+      assert.equal(quotedString(''), "''");
+
+      // String with special characters
+      assert.equal(quotedString('hello\nworld'), "'hello\nworld'");
+      assert.equal(quotedString('tab\there'), "'tab\there'");
+    });
+
+    test('quotedIdentifier', () => {
+      // Basic identifier
+      assert.equal(quotedIdentifier('table_name'), '"table_name"');
+
+      // Identifier with double quotes
+      assert.equal(quotedIdentifier('my"table'), '"my""table"');
+      assert.equal(quotedIdentifier('"column"'), '"""column"""');
+
+      // Identifier with multiple double quotes
+      assert.equal(quotedIdentifier('my"special"table'), '"my""special""table"');
+
+      // Empty identifier
+      assert.equal(quotedIdentifier(''), '""');
+
+      // Identifier with special characters
+      assert.equal(quotedIdentifier('table-name'), '"table-name"');
+      assert.equal(quotedIdentifier('table.name'), '"table.name"');
+      assert.equal(quotedIdentifier('table name'), '"table name"');
+    });
+  });
 });