Fix format-check job on CI (1.5)

This is a backport of the PR #387 to `v1.5-variegata` stable branch.

`CodeQuality.yml` job has started failing ([example](https://github.com/duckdb/duckdb-odbc/actions/runs/21621925131/job/62312692935?pr=385))
due to the `black` package update.

This PR cleans up the job and pins the `black` package to the known
compatible version.

Author: staticlibs

.github/workflows/CodeQuality.yml

@@ -6,93 +6,39 @@ on:
     branches:
       - '**'
       - '!main'
-      - '!feature'
     paths-ignore:
       - '**.md'
-      - '.github/patches/duckdb-wasm/**'
       - '.github/workflows/**'
-      - '!.github/workflows/lcov_exclude'
       - '!.github/workflows/CodeQuality.yml'
 
   pull_request:
     types: [opened, reopened, ready_for_review, synchronize]
     paths-ignore:
       - '**.md'
       - '.github/workflows/**'
-      - '!.github/workflows/lcov_exclude'
       - '!.github/workflows/CodeQuality.yml'
 
-concurrency:
-  group: ${{ github.workflow }}-${{ github.ref }}-${{ github.head_ref || '' }}-${{ github.base_ref || '' }}-${{ github.ref != 'refs/heads/main' || github.sha }}
-  cancel-in-progress: true
-
-env:
-  GH_TOKEN: ${{ secrets.GH_TOKEN }}
-
 jobs:
   format-check:
     name: Format Check
-    runs-on: ubuntu-22.04
-    if: ${{ !(github.event_name == 'pull_request' && github.head_ref == 'vendoring') }}
-
-    env:
-      CC: gcc-10
-      CXX: g++-10
-      GEN: ninja
+    runs-on: ubuntu-latest
+    if: ${{ !(github.event_name == 'pull_request' && startsWith(github.head_ref, 'vendoring-')) }}
 
     steps:
       - uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
 
       - name: Install
-        shell: bash
         run: |
-          sudo apt-get update -y -qq
-          sudo apt-get install -y -qq ninja-build clang-format-11
-          sudo pip3 install cmake-format black clang_format==11.0.1
+          sudo pip3 install      \
+            black==25.1.0        \
+            clang_format==11.0.1 \
+            cmake-format==0.6.13
 
       - name: Format Check
-        shell: bash
         run: |
+          python -m pip show black
+          python -m pip show cmake_format
+          python -m pip show clang_format
           clang-format --version
           clang-format --dump-config
-          black --version
           make format-check-silent
-
-#  tidy-check:
-#    name: Tidy Check
-#    runs-on: ubuntu-22.04
-#    needs: format-check
-#
-#    env:
-#      CC: gcc-10
-#      CXX: g++-10
-#      GEN: ninja
-#      TIDY_THREADS: 4
-#
-#    steps:
-#      - uses: actions/checkout@v4
-#        with:
-#          fetch-depth: 0
-#
-#      - name: Install
-#        shell: bash
-#        run: sudo apt-get update -y -qq && sudo apt-get install -y -qq ninja-build clang-tidy && sudo pip3 install pybind11[global]
-#
-#      - name: Setup Ccache
-#        uses: hendrikmuhs/ccache-action@main
-#        with:
-#          key: ${{ github.job }}
-#          save: ${{ github.ref == 'refs/heads/main' || github.repository != 'duckdb/duckdb' }}
-#      - name: Download clang-tidy-cache
-#        shell: bash
-#        run: |
-#          set -e
-#          curl -Lo /tmp/clang-tidy-cache https://github.com/ejfitzgerald/clang-tidy-cache/releases/download/v0.4.0/clang-tidy-cache-linux-amd64
-#          md5sum /tmp/clang-tidy-cache | grep 880b290d7bbe7c1fb2a4f591f9a86cc1
-#          chmod +x /tmp/clang-tidy-cache
-#
-#      - name: Tidy Check
-#        shell: bash
-#        run: make tidy-check TIDY_BINARY=/tmp/clang-tidy-cache

Makefile

@@ -28,6 +28,9 @@ format-fix:
 	rm -rf src/amalgamation/*
 	python3 scripts/format.py --all --fix --noconfirm
 
+format-check:
+	python3 scripts/format.py --all --check
+
 format-check-silent:
 	python3 scripts/format.py --all --check --silent