Skip to content

Commit 252b2ec

Browse files
committed
build: add Windows 3.14t build flags - CMAKE_C_FLAGS was modifying defaults, CMAKE_C_FLAGS_INIT preserves them
1 parent 3a9949b commit 252b2ec

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

.github/workflows/packaging_wheels.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,6 @@ jobs:
4545
- { minimal: true, python: cp311 }
4646
- { minimal: true, python: cp312 }
4747
- { minimal: true, platform: { arch: universal2 } }
48-
# Windows+cp314t disabled due to test failures in CI.
49-
# TODO: Diagnose why tests fail (access violations) in some configurations
50-
- { python: cp314t, platform: { os: windows-2025 } }
5148

5249
runs-on: ${{ matrix.platform.os }}
5350
env:

pyproject.toml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,15 @@ if.env.COVERAGE = false
123123
inherit.cmake.define = "append"
124124
cmake.define.DISABLE_UNITY = "1"
125125

126+
[[tool.scikit-build.overrides]]
127+
if.platform-system = "^win32"
128+
if.abi-flags = "t"
129+
inherit.cmake.define = "append"
130+
# /DPy_GIL_DISABLED: needed else the build will try to link python314.lib
131+
# CMAKE_..._FLAGS_INIT not FLAGS: otherwise, msbuild will disable important defaults such as /EHsc
132+
cmake.define.CMAKE_C_FLAGS_INIT="/DPy_MOD_GIL_USED /DPy_GIL_DISABLED"
133+
cmake.define.CMAKE_CXX_FLAGS_INIT="/DPy_MOD_GIL_USED /DPy_GIL_DISABLED"
134+
126135
[tool.scikit-build.sdist]
127136
include = [
128137
"README.md",

0 commit comments

Comments
 (0)