From 1fc4ccb7f1a166d16b4f3abf42836563fb4b22e7 Mon Sep 17 00:00:00 2001 From: Evert Lammerts Date: Fri, 26 Sep 2025 11:06:27 +0200 Subject: [PATCH 1/3] bump submodule --- external/duckdb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/external/duckdb b/external/duckdb index 7992e70b..4bfb6e2f 160000 --- a/external/duckdb +++ b/external/duckdb @@ -1 +1 @@ -Subproject commit 7992e70b4d548ca604e34e55dfc69f960e7500c9 +Subproject commit 4bfb6e2f8c74c7a02e25ca80bad68456270e545b From 1ff99dd63de5ce4681b16361d5d15e480194452a Mon Sep 17 00:00:00 2001 From: Evert Lammerts Date: Fri, 26 Sep 2025 12:54:41 +0200 Subject: [PATCH 2/3] skip failing test while bug is fixed in core --- tests/fast/test_replacement_scan.py | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/tests/fast/test_replacement_scan.py b/tests/fast/test_replacement_scan.py index 0cf69356..365ac2a2 100644 --- a/tests/fast/test_replacement_scan.py +++ b/tests/fast/test_replacement_scan.py @@ -288,15 +288,15 @@ def test_cte_with_joins(self, duckdb_cursor): WHERE a < 3 ) SELECT * FROM ( - SELECT - cte1.*, + SELECT + cte1.*, cte2.a AS cte2_a, subquery.a AS cte3_a FROM cte1 JOIN cte2 ON cte1.a = cte2.a JOIN ( - SELECT - df.*, + SELECT + df.*, cte3.a AS cte3_a FROM df JOIN cte3 ON df.a = cte3.a @@ -330,6 +330,7 @@ def test_same_name_cte(self, duckdb_cursor): res = rel.fetchall() assert res == [(2,), (3,), (4,)] + @pytest.mark.xfail(reason="Bug in DuckDB core (MRE at #19154)") def test_use_with_view(self, duckdb_cursor): rel = create_relation(duckdb_cursor, "select * from df") rel.create_view('v1') @@ -417,8 +418,8 @@ def test_cte_at_different_levels(self, duckdb_cursor): WITH cte1 AS ( SELECT * FROM df ) - SELECT - cte1.*, + SELECT + cte1.*, cte2.a AS cte2_a, subquery.a AS cte3_a FROM cte1 @@ -434,8 +435,8 @@ def test_cte_at_different_levels(self, duckdb_cursor): SELECT * FROM df WHERE a < 3 ) - SELECT - df.*, + SELECT + df.*, cte3.a AS cte3_a FROM ( SELECT * FROM df From 9dc21dad229c575350fff784a7448762323c811d Mon Sep 17 00:00:00 2001 From: Evert Lammerts Date: Fri, 26 Sep 2025 13:27:17 +0200 Subject: [PATCH 3/3] now xfail correct test :/ --- tests/fast/test_replacement_scan.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fast/test_replacement_scan.py b/tests/fast/test_replacement_scan.py index 365ac2a2..233439df 100644 --- a/tests/fast/test_replacement_scan.py +++ b/tests/fast/test_replacement_scan.py @@ -309,6 +309,7 @@ def test_cte_with_joins(self, duckdb_cursor): res = rel.fetchall() assert res == [(2, 2, 2)] + @pytest.mark.xfail(reason="Bug in DuckDB core (MRE at #19154)") def test_same_name_cte(self, duckdb_cursor): query = """ WITH df AS ( @@ -330,7 +331,6 @@ def test_same_name_cte(self, duckdb_cursor): res = rel.fetchall() assert res == [(2,), (3,), (4,)] - @pytest.mark.xfail(reason="Bug in DuckDB core (MRE at #19154)") def test_use_with_view(self, duckdb_cursor): rel = create_relation(duckdb_cursor, "select * from df") rel.create_view('v1')