From 3b91c89fcdcbadc5b900b7795dcc9f9f7f1f78af Mon Sep 17 00:00:00 2001 From: Mauricio Vargas Sepulveda Date: Mon, 6 Oct 2025 10:57:33 -0400 Subject: [PATCH 1/3] https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-debian-gcc/duckdb-00check.html --- src/reltoaltrep.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/reltoaltrep.cpp b/src/reltoaltrep.cpp index 4dfe9546c..1b60337ea 100644 --- a/src/reltoaltrep.cpp +++ b/src/reltoaltrep.cpp @@ -218,6 +218,7 @@ struct AltrepRownamesWrapper { AltrepRownamesWrapper(duckdb::shared_ptr rel_p) : rel(rel_p) { rowlen_data[0] = NA_INTEGER; + rowlen_data[1] = 0; } static AltrepRownamesWrapper *Get(SEXP x) { From e998cf6c3665f8617b04ac332d3d45b87d0985e7 Mon Sep 17 00:00:00 2001 From: Mauricio Vargas Sepulveda Date: Mon, 6 Oct 2025 11:03:37 -0400 Subject: [PATCH 2/3] include/rfuns_extension.hpp:47 IOT instruction (core dumped) --- src/include/rfuns_extension.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/include/rfuns_extension.hpp b/src/include/rfuns_extension.hpp index 5ebf83b2f..0c78a1a38 100644 --- a/src/include/rfuns_extension.hpp +++ b/src/include/rfuns_extension.hpp @@ -44,7 +44,7 @@ BinaryChunk BinaryTypeAssert(DataChunk &args) { D_ASSERT(lefts.GetType() == LHS_LOGICAL_TYPE); auto &rights = args.data[1]; - D_ASSERT(rights.GetType() == LHS_LOGICAL_TYPE); + D_ASSERT(rights.GetType() == RHS_LOGICAL_TYPE); return {lefts, rights}; } From 681d7e11202fa8b699854ecf2dd94c49b97850eb Mon Sep 17 00:00:00 2001 From: Mauricio Vargas Sepulveda Date: Mon, 6 Oct 2025 11:08:57 -0400 Subject: [PATCH 3/3] fix https://www.stats.ox.ac.uk/pub/bdr/memtests/valgrind/duckdb/tests/testthat.Rout --- patch/0030-init-sort-progress.patch | 27 +++++++++++++++++++ patch/0031-fix-rfuns-binary-type-assert.patch | 26 ++++++++++++++++++ 2 files changed, 53 insertions(+) create mode 100644 patch/0030-init-sort-progress.patch create mode 100644 patch/0031-fix-rfuns-binary-type-assert.patch diff --git a/patch/0030-init-sort-progress.patch b/patch/0030-init-sort-progress.patch new file mode 100644 index 000000000..fd84bd302 --- /dev/null +++ b/patch/0030-init-sort-progress.patch @@ -0,0 +1,27 @@ +From 5f3e4a2015f9898ad7cfc77300b65779640f1fad Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?MVS +Date: Sun, 6 Oct 2025 09:30:00 +0200 +Subject: [PATCH] init-sort-progress + +Initialize uninitialized member variables in SortGlobalSinkState to fix valgrind warnings. + +--- + src/duckdb/src/common/sorting/sort.cpp | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/src/duckdb/src/common/sorting/sort.cpp b/src/duckdb/src/common/sorting/sort.cpp +index 2f5463e3f..1a8570451 100644 +--- a/src/duckdb/src/common/sorting/sort.cpp ++++ b/src/duckdb/src/common/sorting/sort.cpp +@@ -17,7 +17,8 @@ namespace duckdb { + class SortGlobalSinkState : public GlobalSinkState { + public: + SortGlobalSinkState(ClientContext &context) +- : table(context, vector(), CreateInitialSortState()) { ++ : GlobalSinkState(), table(context, vector(), CreateInitialSortState()), ++ sorted_blocks(), sorted_blocks_temp() { + } + + void AddLocalState(ExecutionContext &context, LocalSinkState &lstate_p); +-- +2.34.1 diff --git a/patch/0031-fix-rfuns-binary-type-assert.patch b/patch/0031-fix-rfuns-binary-type-assert.patch new file mode 100644 index 000000000..d95fb29ef --- /dev/null +++ b/patch/0031-fix-rfuns-binary-type-assert.patch @@ -0,0 +1,26 @@ +From 6a4e5b3025f9898ad7cfc77300b65779640f1fad Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?MVS +Date: Sun, 6 Oct 2025 09:35:00 +0200 +Subject: [PATCH] fix-rfuns-binary-type-assert + +Fix BinaryTypeAssert template function to use correct type parameter for right vector validation. + +--- + src/duckdb/extension/core_functions/include/rfuns_extension.hpp | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/src/duckdb/extension/core_functions/include/rfuns_extension.hpp b/src/duckdb/extension/core_functions/include/rfuns_extension.hpp +index 2f5463e3f..1a8570451 100644 +--- a/src/duckdb/extension/core_functions/include/rfuns_extension.hpp ++++ b/src/duckdb/extension/core_functions/include/rfuns_extension.hpp +@@ -44,7 +44,7 @@ BinaryChunk BinaryTypeAssert(DataChunk &args) { + D_ASSERT(lefts.GetType() == LHS_LOGICAL_TYPE); + + auto &rights = args.data[1]; +- D_ASSERT(rights.GetType() == LHS_LOGICAL_TYPE); ++ D_ASSERT(rights.GetType() == RHS_LOGICAL_TYPE); + + return {lefts, rights}; + } +-- +2.34.1