fix clippy

Change-Id: I41f9e0bf81b34a0c5bc17a2e2b2ede7336eee75f

Author: wangfenjin

Makefile

@@ -7,5 +7,5 @@ DUCKDB_LIB_DIR = /Users/wangfenjin/duckdb
 DUCKDB_INCLUDE_DIR = /Users/wangfenjin/duckdb
 
 all:
-	cargo test --features buildtime_bindgen -- --nocapture
-	cargo clippy --all-targets --workspace --features buildtime_bindgen -- -D warnings -A clippy::redundant-closure
+	cargo test --features buildtime_bindgen --features modern-full -- --nocapture
+	cargo clippy --all-targets --workspace --features buildtime_bindgen --features modern-full -- -D warnings -A clippy::redundant-closure

src/types/chrono.rs

@@ -57,9 +57,9 @@ impl FromSql for NaiveDateTime {
             ValueRef::Timestamp(tu, t) => {
                 let (secs, nsecs) = match tu {
                     TimeUnit::Second => (t, 0),
-                    TimeUnit::Millisecond => (t / 1000, (t % 1000) * 1000_000),
-                    TimeUnit::Microsecond => (t / 1000_000, (t % 1000_000) * 1000),
-                    TimeUnit::Nanosecond => (t / 1000_000_000, t % 1000_000_000),
+                    TimeUnit::Millisecond => (t / 1000, (t % 1000) * 1_000_000),
+                    TimeUnit::Microsecond => (t / 1_000_000, (t % 1_000_000) * 1000),
+                    TimeUnit::Nanosecond => (t / 1_000_000_000, t % 1_000_000_000),
                 };
                 Ok(NaiveDateTime::from_timestamp(secs, nsecs as u32))
             }

src/types/from_sql.rs

@@ -171,22 +171,12 @@ impl FromSql for String {
     #[inline]
     fn column_result(value: ValueRef<'_>) -> FromSqlResult<Self> {
         match value {
-            ValueRef::Date32(d) => {
-                if cfg!(feature = "chrono") {
-                    Ok(chrono::NaiveDate::column_result(value)?.format("%F").to_string())
-                } else {
-                    Ok(d.to_string())
-                }
-            }
-            ValueRef::Timestamp(_, t) => {
-                if cfg!(feature = "chrono") {
-                    Ok(chrono::NaiveDateTime::column_result(value)?
-                        .format("%F %T%.f")
-                        .to_string())
-                } else {
-                    Ok(t.to_string())
-                }
-            }
+            #[cfg(feature = "chrono")]
+            ValueRef::Date32(_) => Ok(chrono::NaiveDate::column_result(value)?.format("%F").to_string()),
+            #[cfg(feature = "chrono")]
+            ValueRef::Timestamp(..) => Ok(chrono::NaiveDateTime::column_result(value)?
+                .format("%F %T%.f")
+                .to_string()),
             _ => value.as_str().map(ToString::to_string),
         }
     }