Skip to content

Commit 4a64868

Browse files
authored
Fix vscalar feature to depend on vtab-arrow (#542)
The vscalar feature uses WritableVector from the vtab::arrow module. Fixes #441
2 parents 7b88cbc + 9fa3973 commit 4a64868

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

crates/duckdb/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ default = []
2020
bundled = ["libduckdb-sys/bundled"]
2121
json = ["libduckdb-sys/json", "bundled"]
2222
parquet = ["libduckdb-sys/parquet", "bundled"]
23-
vscalar = []
23+
vscalar = ["vtab-arrow"]
2424
vscalar-arrow = []
2525
vtab = []
2626
vtab-loadable = ["vtab", "duckdb-loadable-macros"]

crates/duckdb/src/vtab/arrow.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1218,6 +1218,7 @@ mod test {
12181218
}
12191219

12201220
#[test]
1221+
#[cfg(feature = "appender-arrow")]
12211222
fn test_append_struct() -> Result<(), Box<dyn Error>> {
12221223
let db = Connection::open_in_memory()?;
12231224
db.execute_batch("CREATE TABLE t1 (s STRUCT(v VARCHAR, i INTEGER))")?;
@@ -1254,6 +1255,7 @@ mod test {
12541255
}
12551256

12561257
#[test]
1258+
#[cfg(feature = "appender-arrow")]
12571259
fn test_append_struct_contains_null() -> Result<(), Box<dyn Error>> {
12581260
let db = Connection::open_in_memory()?;
12591261
db.execute_batch("CREATE TABLE t1 (s STRUCT(v VARCHAR, i INTEGER))")?;

0 commit comments

Comments
 (0)