Skip to content

Commit 79417fb

Browse files
Set the default min version when min_duckdb_version is not specified (#473)
1 parent 1ed5b12 commit 79417fb

File tree

1 file changed

+6
-3
lines changed
  • crates/duckdb-loadable-macros/src

1 file changed

+6
-3
lines changed

crates/duckdb-loadable-macros/src/lib.rs

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ use darling::{ast::NestedMeta, Error, FromMeta};
1010

1111
use std::env;
1212

13+
const DEFAULT_DUCKDB_VERSION: &str = "v1.2.0";
14+
1315
/// For parsing the arguments to the duckdb_entrypoint_c_api macro
1416
#[derive(Debug, FromMeta)]
1517
struct CEntryPointMacroArgs {
@@ -40,9 +42,10 @@ pub fn duckdb_entrypoint_c_api(attr: TokenStream, item: TokenStream) -> TokenStr
4042
};
4143

4244
// Set the minimum duckdb version (dev by default)
43-
let minimum_duckdb_version = match args.min_duckdb_version {
44-
Some(i) => i,
45-
None => env::var("DUCKDB_EXTENSION_MIN_DUCKDB_VERSION").expect("Please either set env var DUCKDB_EXTENSION_MIN_DUCKDB_VERSION or pass it as an argument to the proc macro").to_string()
45+
let minimum_duckdb_version = match (args.min_duckdb_version, env::var("DUCKDB_EXTENSION_MIN_DUCKDB_VERSION")) {
46+
(Some(i), _) => i,
47+
(None, Ok(i)) => i.to_string(),
48+
_ => DEFAULT_DUCKDB_VERSION.to_string(),
4649
};
4750

4851
let extension_name = match (args.ext_name, env::var("DUCKDB_EXTENSION_NAME")) {

0 commit comments

Comments
 (0)