Skip to content

Commit 8b928cc

Browse files
committed
Remove redundant flush and close calls in Appender Drop
`duckdb_appender_destroy` already handles flushing and closing internally, making explicit calls unnecessary and potentially unsafe for partial rows.
1 parent 803459f commit 8b928cc

File tree

1 file changed

+0
-2
lines changed
  • crates/duckdb/src/appender

1 file changed

+0
-2
lines changed

crates/duckdb/src/appender/mod.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -161,9 +161,7 @@ impl Appender<'_> {
161161
impl Drop for Appender<'_> {
162162
fn drop(&mut self) {
163163
if !self.app.is_null() {
164-
let _ = self.flush(); // can't safely handle failures here
165164
unsafe {
166-
ffi::duckdb_appender_close(self.app);
167165
ffi::duckdb_appender_destroy(&mut self.app);
168166
}
169167
}

0 commit comments

Comments
 (0)