Skip to content

Commit 9f2daa4

Browse files
committed
Use query_one in more places
1 parent a44657a commit 9f2daa4

File tree

3 files changed

+9
-19
lines changed

3 files changed

+9
-19
lines changed

crates/duckdb/src/statement.rs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -662,9 +662,8 @@ mod test {
662662

663663
let mut stmt = db.prepare("SELECT id FROM test where name = ?")?;
664664
{
665-
let mut rows = stmt.query([&"one"])?;
666-
let id: Result<i32> = rows.next()?.unwrap().get(0);
667-
assert_eq!(Ok(1), id);
665+
let id: i32 = stmt.query_one([&"one"], |r| r.get(0))?;
666+
assert_eq!(id, 1);
668667
}
669668
Ok(())
670669
}

crates/duckdb/src/types/mod.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,6 @@ mod test {
312312

313313
let mut stmt = db.prepare("SELECT b, t, i, f, n FROM foo")?;
314314
let mut rows = stmt.query([])?;
315-
316315
let row = rows.next()?.unwrap();
317316

318317
// check the correct types come back as expected
@@ -371,7 +370,6 @@ mod test {
371370

372371
let mut stmt = db.prepare("SELECT b, t, i, f, n FROM foo")?;
373372
let mut rows = stmt.query([])?;
374-
375373
let row = rows.next()?.unwrap();
376374
// NOTE: this is different from SQLite
377375
// assert_eq!(Value::Blob(vec![1, 2]), row.get::<_, Value>(0)?);

crates/duckdb/src/types/to_sql.rs

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -316,10 +316,7 @@ mod test {
316316

317317
db.execute("INSERT INTO foo (id) VALUES (gen_random_uuid())", [])?;
318318

319-
let mut stmt = db.prepare("SELECT id FROM foo")?;
320-
let mut rows = stmt.query([])?;
321-
let row = rows.next()?.unwrap();
322-
let found_id: String = row.get_unwrap(0);
319+
let found_id: String = db.prepare("SELECT id FROM foo")?.query_one([], |r| r.get(0))?;
323320
assert_eq!(found_id.len(), 36);
324321
Ok(())
325322
}
@@ -337,11 +334,9 @@ mod test {
337334
let id_vec = id.as_bytes().to_vec();
338335
db.execute("INSERT INTO foo (id, label) VALUES (?, ?)", params![id_vec, "target"])?;
339336

340-
let mut stmt = db.prepare("SELECT id, label FROM foo WHERE id = ?")?;
341-
let mut rows = stmt.query(params![id_vec])?;
342-
let row = rows.next()?.unwrap();
343-
let found_id: Uuid = row.get_unwrap(0);
344-
let found_label: String = row.get_unwrap(1);
337+
let (found_id, found_label): (Uuid, String) = db
338+
.prepare("SELECT id, label FROM foo WHERE id = ?")?
339+
.query_one(params![id_vec], |r| Ok((r.get_unwrap(0), r.get_unwrap(1))))?;
345340
assert_eq!(found_id, id);
346341
assert_eq!(found_label, "target");
347342
Ok(())
@@ -359,11 +354,9 @@ mod test {
359354
let id = Uuid::new_v4();
360355
db.execute("INSERT INTO foo (id, label) VALUES (?, ?)", params![id, "target"])?;
361356

362-
let mut stmt = db.prepare("SELECT id, label FROM foo WHERE id = ?")?;
363-
let mut rows = stmt.query(params![id])?;
364-
let row = rows.next()?.unwrap();
365-
let found_id: Uuid = row.get_unwrap(0);
366-
let found_label: String = row.get_unwrap(1);
357+
let (found_id, found_label): (Uuid, String) = db
358+
.prepare("SELECT id, label FROM foo WHERE id = ?")?
359+
.query_one(params![id], |r| Ok((r.get_unwrap(0), r.get_unwrap(1))))?;
367360
assert_eq!(found_id, id);
368361
assert_eq!(found_label, "target");
369362
Ok(())

0 commit comments

Comments
 (0)