Skip to content

Commit bb83764

Browse files
committed
revert arrow decimal tests
1 parent c6ee658 commit bb83764

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

crates/duckdb/src/test_all_types.rs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,7 @@ fn test_large_arrow_types() -> crate::Result<()> {
2222
fn test_with_database(database: &Connection) -> crate::Result<()> {
2323
// uhugeint, time_tz, and dec38_10 aren't supported in the duckdb arrow layer
2424
// union is currently blocked by https://github.com/duckdb/duckdb/pull/11326
25-
let excluded = [
26-
"uhugeint", "time_tz", "dec38_10", "union", "varint", "dec_4_1", "dec_9_4", "dec_18_6",
27-
];
25+
let excluded = ["uhugeint", "time_tz", "dec38_10", "union", "varint"];
2826

2927
let mut binding = database.prepare(&format!(
3028
"SELECT * EXCLUDE ({}) FROM test_all_types()",

crates/duckdb/src/vtab/arrow.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1182,7 +1182,7 @@ mod test {
11821182
db.register_table_function::<ArrowVTab>("arrow")?;
11831183

11841184
let rbs: Vec<RecordBatch> = db
1185-
.prepare("SELECT value::DECIMAL(38,0) as value FROM read_parquet('./examples/int32_decimal.parquet');")?
1185+
.prepare("SELECT * FROM read_parquet('./examples/int32_decimal.parquet');")?
11861186
.query_arrow([])?
11871187
.collect();
11881188
let param = arrow_recordbatch_to_query_params(rbs.into_iter().next().unwrap());
@@ -1192,7 +1192,7 @@ mod test {
11921192
assert_eq!(rb.num_columns(), 1);
11931193
let column = rb.column(0).as_any().downcast_ref::<Decimal128Array>().unwrap();
11941194
assert_eq!(column.len(), 1);
1195-
assert_eq!(column.value(0), i128::from(300));
1195+
assert_eq!(column.value(0), i128::from(30000));
11961196
Ok(())
11971197
}
11981198

@@ -1620,12 +1620,12 @@ mod test {
16201620

16211621
// With custom width and scale
16221622
let array: PrimitiveArray<arrow::datatypes::Decimal128Type> =
1623-
Decimal128Array::from(vec![i128::from(12345)]).with_data_type(DataType::Decimal128(38, 10));
1623+
Decimal128Array::from(vec![i128::from(12345)]).with_data_type(DataType::Decimal128(5, 2));
16241624
check_rust_primitive_array_roundtrip(array.clone(), array)?;
16251625

16261626
// With width and zero scale
16271627
let array: PrimitiveArray<arrow::datatypes::Decimal128Type> =
1628-
Decimal128Array::from(vec![i128::from(12345)]).with_data_type(DataType::Decimal128(38, 0));
1628+
Decimal128Array::from(vec![i128::from(12345)]).with_data_type(DataType::Decimal128(5, 0));
16291629
check_rust_primitive_array_roundtrip(array.clone(), array)?;
16301630

16311631
Ok(())

0 commit comments

Comments
 (0)