First round of CI tweaks (#527)

There's a lot more that can (and should) be done, but this cleanup is a start.

Author: mlafeldt

.github/workflows/release.yaml

@@ -2,7 +2,7 @@ name: CD
 
 on:
   push:
-    tags: [ '*' ]
+    tags: ["*"]
 env:
   RUST_BACKTRACE: 1
 jobs:
@@ -17,7 +17,7 @@ jobs:
       - name: publish crates
         uses: katyo/publish-crates@v2
         with:
-          path: './'
+          path: "./"
           args: --no-verify --allow-dirty --all-features
           registry-token: ${{ secrets.CARGO_REGISTRY_TOKEN }}
           ignore-unpublished-changes: true

.github/workflows/rust.yaml

@@ -2,9 +2,9 @@ name: CI
 
 on:
   push:
-    branches: [ main ]
+    branches: [main]
   pull_request:
-    branches: [ main ]
+    branches: [main]
 env:
   RUST_BACKTRACE: 1
 jobs:
@@ -14,15 +14,16 @@ jobs:
       fail-fast: true
       matrix:
         include:
-          - { target: x86_64-pc-windows-msvc, os: windows-latest, duckdb: libduckdb-windows-amd64.zip }
-          - { target: x86_64-unknown-linux-gnu, os: ubuntu-latest, duckdb: libduckdb-linux-amd64.zip }
-          #- { target: x86_64-apple-darwin, os: macos-latest }
-          #- {
-              #target: x86_64-pc-windows-gnu,
-              #os: windows-latest,
-              #host: -x86_64-pc-windows-gnu,
-            #}
-
+          - {
+              target: x86_64-pc-windows-msvc,
+              os: windows-latest,
+              duckdb: libduckdb-windows-amd64.zip,
+            }
+          - {
+              target: x86_64-unknown-linux-gnu,
+              os: ubuntu-latest,
+              duckdb: libduckdb-linux-amd64.zip,
+            }
     runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v2
@@ -58,6 +59,15 @@ jobs:
           LD_LIBRARY_PATH: ${{ github.workspace }}/libduckdb
         run: cargo clippy --all-targets --all-features --locked -- -D warnings
 
+      - name: Dry-run release of crates
+        if: matrix.os == 'ubuntu-latest'
+        uses: katyo/publish-crates@v2
+        with:
+          path: "./"
+          args: --allow-dirty --all-features
+          dry-run: true
+          ignore-unpublished-changes: true
+
       # For windows
       - name: Windows extract duckdb
         if: matrix.os == 'windows-latest'
@@ -94,35 +104,16 @@ jobs:
           DUCKDB_INCLUDE_DIR: ${{ github.workspace }}/libduckdb
           LD_LIBRARY_PATH: ${{ github.workspace }}/libduckdb
 
-  Windows:
-    name: Windows build from source
-    needs: test
-    runs-on: windows-latest
-    steps:
-      - uses: actions/checkout@v2
-      - uses: actions/cache@v3
-        with:
-          path: ~/.cargo/registry/index
-          key: index-${{ runner.os }}-${{ github.run_number }}
-          restore-keys: |
-            index-${{ runner.os }}-
-      - uses: actions-rust-lang/setup-rust-toolchain@v1
-        with:
-          target: x86_64-pc-windows-msvc
-
-      - run: cargo install cargo-examples
-
   Sanitizer:
     name: Address Sanitizer
-    needs: test
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
       # Need nightly rust.
       - uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
           toolchain: nightly
-          components: 'rust-src'
+          components: "rust-src"
       # Install LLVM tools
       - name: Install LLVM
         run: |
@@ -132,21 +123,9 @@ jobs:
           RUSTFLAGS: -Zsanitizer=address -C debuginfo=0
           RUSTDOCFLAGS: -Zsanitizer=address
           ASAN_OPTIONS: "detect_stack_use_after_return=1:detect_leaks=1:symbolize=1"
-          # Work around https://github.com/rust-lang/rust/issues/59125 by
-          # disabling backtraces. In an ideal world we'd probably suppress the
-          # leak sanitization, but we don't care about backtraces here, so long
-          # as the other tests have them.
-          RUST_BACKTRACE: "0"
         # We cannot run "modern-full" with asan as the chrono feature will auto-load relase binaries of
         # the ICU-extension, which are not built with ASAN and will cause a crash.
         run: |
           export ASAN_SYMBOLIZER_PATH=$(which llvm-symbolizer)
           echo $ASAN_SYMBOLIZER_PATH
           cargo -Z build-std test --features "serde_json url r2d2 uuid polars extensions-full" --target x86_64-unknown-linux-gnu --package duckdb
-      - name: publish crates --dry-run
-        uses: katyo/publish-crates@v2
-        with:
-          path: './'
-          args: --allow-dirty --all-features
-          dry-run: true
-          ignore-unpublished-changes: true