refactor(types): use into_result in from_sql and improve decimal conversion #616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- introduce IntoResult to eliminate is_ok() + unwrap patterns - unify integer conversions using a single-line cast Signed-off-by: Florian Valeye <[email protected]>
…to avoid string allocation Following PostgreSQL, the round_dp_with_strategy(..., MidpointAwayFromZero) gives identical semantics to DuckDB’s Decimal to Integer cast. Signed-off-by: Florian Valeye <[email protected]>
… Text Signed-off-by: Florian Valeye <[email protected]>
fvaleye
force-pushed
the
refactor/from-sql-into-result
branch
from
e6f5495 to
56dd28c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A minor refactoring to handle type conversion, improving
Decimalperformance.Introduced a small new abstraction, IntoResult, to normalize
cast::From<...>::cast(...)return types. This eliminates the need to special-case when' cast' returns a primitive versus aResult<T, _>. Now, a single.into_result(...)call can be used everywhere to convert toResult<T, FromSqlError>.Updated
Decimalhandling to match DuckDB rounding semantics (round half away from zero). Usesrust_decimalto round to an integral mantissa before casting, avoiding string parsing and explicitly encoding the correct semantics.Modified
Textconversion so that the string value is captured once when an error occurs.