Skip to content

Commit 9a77a8e

Browse files
authored
Merge pull request #741 from szarnyasg/nits-20260116
Typo fixes
2 parents f129b24 + ec4c511 commit 9a77a8e

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/spatial/modules/gdal/gdal_module.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ class DuckDBFileSystemHandler final : public VSIFilesystemHandler {
228228
return new DuckDBFileHandle(std::move(file));
229229
}
230230
} catch (std::exception &ex) {
231-
// Failed to open file via DuckDB File System. If this doesnt have a VSI prefix we can return an error here.
231+
// Failed to open file via DuckDB File System. If this doesn't have a VSI prefix we can return an error here.
232232
if (strncmp(file_name, "/vsi", 4) != 0 && !IsStdCharDev(file_name)) {
233233
if (bSetError) {
234234
VSIError(VSIE_FileError, "Failed to open file %s: %s", file_name, ex.what());
@@ -1047,7 +1047,7 @@ struct ST_Read : ArrowTableFunction {
10471047
| `allowed_drivers` | VARCHAR[] | A list of GDAL driver names that are allowed to be used to open the file. If empty, all drivers are allowed. |
10481048
| `sibling_files` | VARCHAR[] | A list of sibling files that are required to open the file. E.g., the ESRI Shapefile driver requires a .shx file to be present. Although most of the time these can be discovered automatically. |
10491049
| `spatial_filter_box` | BOX_2D | If set to a BOX_2D, the table function will only return rows that intersect with the given bounding box. Similar to spatial_filter. |
1050-
| `keep_wkb` | BOOLEAN | If set, the table function will return geometries in a wkb_geometry column with the type WKB_BLOB (which can be cast to BLOB) instead of GEOMETRY. This is useful if you want to use DuckDB with more exotic geometry subtypes that DuckDB spatial doesnt support representing in the GEOMETRY type yet. |
1050+
| `keep_wkb` | BOOLEAN | If set, the table function will return geometries in a wkb_geometry column with the type WKB_BLOB (which can be cast to BLOB) instead of GEOMETRY. This is useful if you want to use DuckDB with more exotic geometry subtypes that DuckDB spatial doesn't support representing in the GEOMETRY type yet. |
10511051
10521052
Note that GDAL is single-threaded, so this table function will not be able to make full use of parallelism.
10531053
@@ -2034,7 +2034,7 @@ void RegisterGDALModule(ExtensionLoader &loader) {
20342034

20352035
// Set GDAL error handler
20362036
CPLSetErrorHandler([](CPLErr e, int code, const char *raw_msg) {
2037-
// DuckDB doesnt do warnings, so we only throw on errors
2037+
// DuckDB doesn't do warnings, so we only throw on errors
20382038
if (e != CE_Failure && e != CE_Fatal) {
20392039
return;
20402040
}

src/spatial/modules/main/spatial_functions_scalar.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4219,7 +4219,7 @@ struct ST_GeomFromHEXWKB {
42194219
static constexpr auto DESCRIPTION = R"(
42204220
Deserialize a GEOMETRY from a HEX(E)WKB encoded string
42214221
4222-
DuckDB spatial doesnt currently differentiate between `WKB` and `EWKB`, so `ST_GeomFromHEXWKB` and `ST_GeomFromHEXEWKB" are just aliases of eachother.
4222+
DuckDB spatial doesn't currently differentiate between `WKB` and `EWKB`, so `ST_GeomFromHEXWKB` and `ST_GeomFromHEXEWKB` are just aliases of each other.
42234223
)";
42244224

42254225
static constexpr auto EXAMPLE = "";

0 commit comments

Comments
 (0)