Skip to content

Commit bc0d1c5

Browse files
committed
Update extension makefiles to support the latest sqllogictest.
1 parent e39f9dc commit bc0d1c5

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

makefiles/c_api_extensions/base.Makefile

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -109,11 +109,11 @@ configure/extension_version.txt:
109109
#############################################
110110

111111
# Note: to override the default test runner, create a symlink to a different venv
112-
TEST_RUNNER=$(PYTHON_VENV_BIN) -m duckdb_sqllogictest
112+
TEST_RUNNER=$(PYTHON_VENV_BIN) -m sqllogic.test_sqllogic
113113

114-
TEST_RUNNER_BASE=$(TEST_RUNNER) --test-dir test/sql $(EXTRA_EXTENSIONS_PARAM)
115-
TEST_RUNNER_DEBUG=$(TEST_RUNNER_BASE) --external-extension build/debug/$(EXTENSION_NAME).duckdb_extension
116-
TEST_RUNNER_RELEASE=$(TEST_RUNNER_BASE) --external-extension build/release/$(EXTENSION_NAME).duckdb_extension
114+
TEST_RUNNER_BASE=$(TEST_RUNNER) --duckdb-root-dir . --test-dir test/sql $(EXTRA_EXTENSIONS_PARAM)
115+
TEST_RUNNER_DEBUG=$(TEST_RUNNER_BASE) --build-dir ${EXTENSION_BUILD_PATH}/debug
116+
TEST_RUNNER_RELEASE=$(TEST_RUNNER_BASE) --build-dir ${EXTENSION_BUILD_PATH}/release
117117

118118
# By default latest duckdb is installed, set DUCKDB_TEST_VERSION to switch to a different version
119119
DUCKDB_PIP_INSTALL?=duckdb
@@ -129,6 +129,9 @@ ifeq ($(DUCKDB_GIT_VERSION),main)
129129
DUCKDB_PIP_INSTALL=--pre duckdb
130130
endif
131131

132+
# Allow overriding the sqllogictest version in the event of incompatible changes
133+
DUCKDB_SQLLOGICTEST_VERSION?=main
134+
132135
TEST_RELEASE_TARGET=test_extension_release_internal
133136
TEST_DEBUG_TARGET=test_extension_debug_internal
134137

@@ -254,7 +257,9 @@ venv: configure/venv
254257
configure/venv:
255258
$(PYTHON_BIN) -m venv configure/venv
256259
$(PYTHON_VENV_BIN) -m pip install $(DUCKDB_PIP_INSTALL)
257-
$(PYTHON_VENV_BIN) -m pip install git+https://github.com/duckdb/duckdb-sqllogictest-python@2ac8dbc012ddbd96a57dca37784fd8ee3c0eb021
260+
# Restore install from the real repo once https://github.com/duckdb/duckdb-sqllogictest-python/pull/15 is merged
261+
# $(PYTHON_VENV_BIN) -m pip install git+https://github.com/duckdb/duckdb-sqllogictest-python@${DUCKDB_SQLLOGICTEST_VERSION}
262+
$(PYTHON_VENV_BIN) -m pip install git+https://github.com/troycurtisjr/duckdb-sqllogictest-python@update-testing-for-inet
258263
$(PYTHON_VENV_BIN) -m pip install packaging
259264

260265
#############################################

0 commit comments

Comments
 (0)