-
Notifications
You must be signed in to change notification settings - Fork 66
Open
Description
When using TIMESTAMPTZ type in an extension, running tests with make test fails due to a missing pytz Python module dependency.
I think it would be better to make sure that pytz is also installed by make configure.
Steps to Reproduce:
- Implement the extension to use
TIMESTAMPTZtype (see proudust/extension-template-rs:pytz-missing) - Run
make test
Expected Behavior:
Tests should run successfully without dependency errors.
Actual Behavior:
Test fails with the following error:
duckdb.duckdb.InvalidInputException: Invalid Input Error: Required module 'pytz' failed to import, due to the following Python exception:
ModuleNotFoundError: No module named 'pytz'
Full Output
Running DEBUG tests..
[1/1] test/sql/rusty_quack.test
Traceback (most recent call last):
File "", line 198, in _run_module_as_main
File "", line 88, in _run_code
File "/home/proudust/repos/github.com/duckdb/extension-template-rs/configure/venv/lib/python3.13/site-packages/duckdb_sqllogictest/__main__.py", line 3, in
SQLLogicPythonRunner().run()
~~~~~~~~~~~~~~~~~~~~~~~~~~^^
File "/home/proudust/repos/github.com/duckdb/extension-template-rs/configure/venv/lib/python3.13/site-packages/duckdb_sqllogictest/python_runner.py", line 208, in run
result = executor.execute_test(test)
File "/home/proudust/repos/github.com/duckdb/extension-template-rs/configure/venv/lib/python3.13/site-packages/duckdb_sqllogictest/python_runner.py", line 112, in execute_test
res = context.execute()
File "/home/proudust/repos/github.com/duckdb/extension-template-rs/configure/venv/lib/python3.13/site-packages/duckdb_sqllogictest/result.py", line 1314, in execute
method(statement)
~~~~~~^^^^^^^^^^^
File "/home/proudust/repos/github.com/duckdb/extension-template-rs/configure/venv/lib/python3.13/site-packages/duckdb_sqllogictest/result.py", line 899, in execute_query
query_result.check(self, query)
~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^
File "/home/proudust/repos/github.com/duckdb/extension-template-rs/configure/venv/lib/python3.13/site-packages/duckdb_sqllogictest/result.py", line 300, in check
success = compare_values(self, lvalue_str, rvalue_str, current_column)
File "/home/proudust/repos/github.com/duckdb/extension-template-rs/configure/venv/lib/python3.13/site-packages/duckdb_sqllogictest/result.py", line 511, in compare_values
expected = convert_value(expected_str, sql_type)
File "/home/proudust/repos/github.com/duckdb/extension-template-rs/configure/venv/lib/python3.13/site-packages/duckdb_sqllogictest/result.py", line 572, in convert_value
return duckdb.execute(query, [value]).fetchone()[0]
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
duckdb.duckdb.InvalidInputException: Invalid Input Error: Required module 'pytz' failed to import, due to the following Python exception:
ModuleNotFoundError: No module named 'pytz'
make: *** [extension-ci-tools/makefiles/c_api_extensions/base.Makefile:172: test_extension_debug_internal] Error 1
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels