Skip to content

Commit 318ee16

Browse files
authored
feat: allow installation in a non-public schema (#1023)
## Overview Removes `schema = public` from `pg_duckdb.control` to allow installing the extension in a non-public schema. Default behavior is unchanged, `CREATE EXTENSION pg_duckdb` without a `SCHEMA` clause still installs into `public`. In general I agree with the original sentiment: ``` It would be sad for usability if people would have to prefix those with duckdb.read_csv ``` but it would be nice if users can configure this if they want
1 parent dafe12d commit 318ee16

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

pg_duckdb.control

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,3 @@ comment = 'DuckDB Embedded in Postgres'
22
default_version = '1.1.0'
33
module_pathname = '$libdir/pg_duckdb'
44
relocatable = false
5-
schema = public

sql/pg_duckdb--1.0.0.sql

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@ LOAD 'pg_duckdb';
77
-- we'll put into @extschema@ so that in normal usage they get put into the
88
-- public schema and are thus more easily usable. This is the case for the
99
-- read_csv, read_parquet and iceberg functions. It would be sad for usability
10-
-- if people would have to prefix those with duckdb.read_csv
10+
-- if people would have to prefix those with duckdb.read_csv. The extension can
11+
-- also be installed in a non-public schema in which case those functions will
12+
-- require a schema qualified name.
1113
CREATE SCHEMA duckdb;
1214
-- Allow users to see the objects in the duckdb schema. We'll manually revoke rights
1315
-- for the dangerous ones.

0 commit comments

Comments
 (0)