Compilation failure

[Z-Xiao-M]

The code was updated to the latest version, but the compilation failed, do I need to change anything?
@Y-- Hi, I need some help
d1c7caf

ction::PostgresSeqScanInitGlobal(duckdb::ClientContext&, duckdb::TableFunctionInitInput&)’:
src/scan/postgres_seq_scan.cpp:75:16: error: could not convert ‘global_state’ from ‘unique_ptr<pgduckdb::PostgresSeqScanGlobalState,default_delete<pgduckdb::PostgresSeqScanGlobalState>,[...]>’ to ‘unique_ptr<duckdb::GlobalTableFunctionState,default_delete<duckdb::GlobalTableFunctionState>,[...]>’
   75 |         return global_state;
      |                ^~~~~~~~~~~~
      |                |
      |                unique_ptr<pgduckdb::PostgresSeqScanGlobalState,default_delete<pgduckdb::PostgresSeqScanGlobalState>,[...]>
make: *** [/u01/app/halo/product/dbms/16/lib/postgresql/pgxs/src/makefiles/../../src/Makefile.global:966: src/scan/postgres_seq_scan.o] Error 1

[postgres@halo-centos8 pg_duckdb]$ g++ -v
Using built-in specs.
COLLECT_GCC=g++
COLLECT_LTO_WRAPPER=/opt/rh/gcc-toolset-11/root/usr/libexec/gcc/x86_64-redhat-linux/11/lto-wrapper
OFFLOAD_TARGET_NAMES=nvptx-none
OFFLOAD_TARGET_DEFAULT=1
Target: x86_64-redhat-linux
Configured with: ../configure --enable-bootstrap --enable-languages=c,c++,fortran,lto --prefix=/opt/rh/gcc-toolset-11/root/usr --mandir=/opt/rh/gcc-toolset-11/root/usr/share/man --infodir=/opt/rh/gcc-toolset-11/root/usr/share/info --with-bugurl=http://bugzilla.redhat.com/bugzilla --enable-shared --enable-threads=posix --enable-checking=release --enable-multilib --with-system-zlib --enable-__cxa_atexit --disable-libunwind-exceptions --enable-gnu-unique-object --enable-linker-build-id --with-gcc-major-version-only --with-linker-hash-style=gnu --enable-plugin --enable-initfini-array --with-isl=/builddir/build/BUILD/gcc-11.2.1-20210728/obj-x86_64-redhat-linux/isl-install --enable-offload-targets=nvptx-none --without-cuda-driver --enable-gnu-indirect-function --enable-cet --with-tune=generic --with-arch_32=x86-64 --build=x86_64-redhat-linux
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 11.2.1 20210728 (Red Hat 11.2.1-1) (GCC) 

[postgres@halo-centos8 pg_duckdb]$ uname -a
Linux halo-centos8 4.18.0-348.el8.x86_64 #1 SMP Tue Oct 19 15:14:17 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

[Y--]

I'll have a look ASAP, sorry about that.

[JelteF]

Same thing was reported on Discord. Seems we need a std::move around that return (for it to compile on centos 8)

[Z-Xiao-M]

Same thing was reported on Discord. Seems we need a std::move around that return (for it to compile on centos 8)

Yes, the modification will compile normally, this is a simple and good way

[Y--]

Fixed in #456