Skip to content

Commit 00d8f4b

Browse files
authored
Fix: Close button in select mode (#6782)
Task/Issue URL: https://app.asana.com/1/137249556945/project/1207418217763355/task/1211324182553062?focus=true ### Description Fixes an issue when tapping on the selection indicator in select mode would close the tab. ### Steps to test this PR - [ ] Go to the tab switcher - [ ] Tap on the menu button -> Select Tabs - [ ] Tap on the circle (in the corner) on one of the tabs - [ ] Verify the tab is selected, not closed - [ ] Exit the selection mode - [ ] Tap on the close button on one of the tabs - [ ] Verify it closes the tab
1 parent bf2cf88 commit 00d8f4b

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

app/src/main/java/com/duckduckgo/app/tabs/ui/TabSwitcherAdapter.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -236,10 +236,12 @@ class TabSwitcherAdapter(
236236
holder.selectionIndicator.contentDescription = holder.rootView.resources.getString(R.string.tabNotSelectedIndicator)
237237
}
238238
holder.selectionIndicator.show()
239+
holder.close.isClickable = false
239240
holder.close.hide()
240241
}
241242
else -> {
242243
holder.selectionIndicator.hide()
244+
holder.close.isClickable = true
243245
holder.close.show()
244246
}
245247
}

0 commit comments

Comments
 (0)