Skip to content

Commit 0249a74

Browse files
Enable serp variants (#1245)
1 parent b72efd6 commit 0249a74

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

app/src/androidTest/java/com/duckduckgo/app/statistics/VariantManagerTest.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,14 @@ class VariantManagerTest {
3232
@Test
3333
fun serpControlVariantHasExpectedWeightAndNoFeatures() {
3434
val variant = variants.first { it.key == "sc" }
35-
assertEqualsDouble(0.0, variant.weight)
35+
assertEqualsDouble(1.0, variant.weight)
3636
assertEquals(0, variant.features.size)
3737
}
3838

3939
@Test
4040
fun serpExperimentalVariantHasExpectedWeightAndNoFeatures() {
4141
val variant = variants.first { it.key == "se" }
42-
assertEqualsDouble(0.0, variant.weight)
42+
assertEqualsDouble(1.0, variant.weight)
4343
assertEquals(0, variant.features.size)
4444
}
4545

@@ -73,14 +73,14 @@ class VariantManagerTest {
7373
@Test
7474
fun newInBrowserControlVariantHasExpectedWeightAndNoFeatures() {
7575
val variant = variants.first { it.key == "zx" }
76-
assertEqualsDouble(1.0, variant.weight)
76+
assertEqualsDouble(0.0, variant.weight)
7777
assertEquals(0, variant.features.size)
7878
}
7979

8080
@Test
8181
fun newInBrowserInAppUsageVariantHasExpectedWeightAndKillOnboardingAndInAppUsageFeatures() {
8282
val variant = variants.first { it.key == "zy" }
83-
assertEqualsDouble(1.0, variant.weight)
83+
assertEqualsDouble(0.0, variant.weight)
8484
assertEquals(2, variant.features.size)
8585
assertTrue(variant.hasFeature(KillOnboarding))
8686
assertTrue(variant.hasFeature(InAppUsage))

statistics/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,16 +43,16 @@ interface VariantManager {
4343
val ACTIVE_VARIANTS = listOf(
4444
// SERP variants. "sc" may also be used as a shared control for mobile experiments in
4545
// the future if we can filter by app version
46-
Variant(key = "sc", weight = 0.0, features = emptyList(), filterBy = { isSerpRegionToggleCountry() }),
47-
Variant(key = "se", weight = 0.0, features = emptyList(), filterBy = { isSerpRegionToggleCountry() }),
46+
Variant(key = "sc", weight = 1.0, features = emptyList(), filterBy = { isSerpRegionToggleCountry() }),
47+
Variant(key = "se", weight = 1.0, features = emptyList(), filterBy = { isSerpRegionToggleCountry() }),
4848

4949
// InAppUsage Experiments
5050
Variant(key = "ma", weight = 0.0, features = emptyList(), filterBy = { isEnglishLocale() }),
5151
Variant(key = "mb", weight = 0.0, features = listOf(VariantFeature.KillOnboarding, VariantFeature.RemoveDay1AndDay3Notifications), filterBy = { isEnglishLocale() }),
5252
Variant(key = "mc", weight = 0.0, features = listOf(VariantFeature.KillOnboarding, VariantFeature.InAppUsage, VariantFeature.RemoveDay1AndDay3Notifications), filterBy = { isEnglishLocale() }),
5353

54-
Variant(key = "zx", weight = 1.0, features = emptyList(), filterBy = { isEnglishLocale() }),
55-
Variant(key = "zy", weight = 1.0, features = listOf(VariantFeature.KillOnboarding, VariantFeature.InAppUsage), filterBy = { isEnglishLocale() })
54+
Variant(key = "zx", weight = 0.0, features = emptyList(), filterBy = { isEnglishLocale() }),
55+
Variant(key = "zy", weight = 0.0, features = listOf(VariantFeature.KillOnboarding, VariantFeature.InAppUsage), filterBy = { isEnglishLocale() })
5656
)
5757

5858
val REFERRER_VARIANTS = listOf(

0 commit comments

Comments
 (0)