Skip to content

Commit 0374f66

Browse files
authored
Left-align text in individual overflow menus in password manager (#4699)
Task/Issue URL: https://app.asana.com/0/608920331025315/1207675108702975/f ### Description Left-aligns the text for overflow menus of the individual passwords in the password management screen. This makes it consistent with such menus used elsewhere. ### Steps to test this PR QA-optional ### UI changes ![combined](https://github.com/duckduckgo/Android/assets/1336281/1e0feb67-b31e-4650-bd36-aa24a3892794)
1 parent 9d674a4 commit 0374f66

File tree

1 file changed

+16
-17
lines changed

1 file changed

+16
-17
lines changed

autofill/autofill-impl/src/main/res/layout/overflow_menu_list_item.xml

Lines changed: 16 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -18,37 +18,36 @@
1818
android:layout_width="match_parent"
1919
android:layout_height="wrap_content"
2020
xmlns:app="http://schemas.android.com/apk/res-auto"
21-
xmlns:tools="http://schemas.android.com/tools"
2221
android:orientation="vertical"
2322
android:background="@drawable/popup_menu_bg">
2423

25-
<TextView
26-
tools:ignore="DeprecatedWidgetInXml"
24+
<com.duckduckgo.common.ui.view.PopupMenuItemView
2725
android:id="@+id/item_copy_username"
28-
style="@style/Widget.DuckDuckGo.PopupMenuItem"
29-
android:text="@string/credentialManagementEditButtonCopyUsername" />
26+
android:layout_width="match_parent"
27+
android:layout_height="wrap_content"
28+
app:primaryText="@string/credentialManagementEditButtonCopyUsername" />
3029

31-
<TextView
32-
tools:ignore="DeprecatedWidgetInXml"
30+
<com.duckduckgo.common.ui.view.PopupMenuItemView
3331
android:id="@+id/item_copy_password"
34-
style="@style/Widget.DuckDuckGo.PopupMenuItem"
35-
android:text="@string/credentialManagementEditButtonCopyPassword" />
32+
android:layout_width="match_parent"
33+
android:layout_height="wrap_content"
34+
app:primaryText="@string/credentialManagementEditButtonCopyPassword" />
3635

3736
<com.duckduckgo.common.ui.view.divider.HorizontalDivider
3837
app:defaultPadding="false"
3938
android:layout_width="wrap_content"
4039
android:layout_height="wrap_content" />
4140

42-
<TextView
43-
tools:ignore="DeprecatedWidgetInXml"
41+
<com.duckduckgo.common.ui.view.PopupMenuItemView
4442
android:id="@+id/item_overflow_edit"
45-
style="@style/Widget.DuckDuckGo.PopupMenuItem"
46-
android:text="@string/credentialManagementViewMenuEdit" />
43+
android:layout_width="match_parent"
44+
android:layout_height="wrap_content"
45+
app:primaryText="@string/credentialManagementViewMenuEdit" />
4746

48-
<TextView
49-
tools:ignore="DeprecatedWidgetInXml"
47+
<com.duckduckgo.common.ui.view.PopupMenuItemView
5048
android:id="@+id/item_overflow_delete"
51-
style="@style/Widget.DuckDuckGo.PopupMenuItem"
52-
android:text="@string/credentialManagementViewMenuDelete" />
49+
android:layout_width="match_parent"
50+
android:layout_height="wrap_content"
51+
app:primaryText="@string/credentialManagementViewMenuDelete" />
5352

5453
</LinearLayout>

0 commit comments

Comments
 (0)