Update autofill to 17.2.0 (#6089)

Task/Issue URL:
https://app.asana.com/1/137249556945/task/1210272268839645
Autofill Release:
https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/17.2.0


## Description
Updates Autofill to version
[17.2.0](https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/17.2.0).

### Autofill 17.2.0 release notes
## What's Changed
* Update password-related json files (2025-04-15) by @daxmobile in
duckduckgo/duckduckgo-autofill#797
* [SiteSpecificFixes] Add support for input types by @dbajpeyi in
duckduckgo/duckduckgo-autofill#795
* [SiteSpecificFeature] Add readme for site-specific-feature by
@dbajpeyi in duckduckgo/duckduckgo-autofill#799
* build: add missing precompile-regexes step by @shakyShane in
duckduckgo/duckduckgo-autofill#807
* build: exclude generated regex folder from watch by @shakyShane in
duckduckgo/duckduckgo-autofill#808
* Update password-related json files (2025-05-05) by @daxmobile in
duckduckgo/duckduckgo-autofill#806
* Update password-related json files (2025-05-06) by @daxmobile in
duckduckgo/duckduckgo-autofill#810
* Add credit card and identity for Windows by @borgateo in
duckduckgo/duckduckgo-autofill#796
* Ema/cc forms fixes by @GioSensation in
duckduckgo/duckduckgo-autofill#809
* Recategorize password variant by @GioSensation in
duckduckgo/duckduckgo-autofill#818
* Update password-related json files (2025-05-16) by @daxmobile in
duckduckgo/duckduckgo-autofill#822


**Full Changelog**:
duckduckgo/duckduckgo-autofill@17.1.0...17.2.0

## Steps to test
This release has been tested during autofill development. For smoke test
steps see [this
task](https://app.asana.com/0/1198964220583541/1200583647142330/f).

- [ ] Add logcat filter for `message~:"autofill-config"`
- [ ] Build `internal` type (e.g., `/.gradlew installID`)
- [ ] [Assuming remote config isn't merged yet] Open any website, verify
`"password_variant_categorization" : false`
- [ ] Visit `Settings -> Feature Flag Inventory` and enable
`passwordVariantCategorization`
- [ ] Return to webpage and refresh; verify
`"password_variant_categorization" : true`
- [ ] Verify autofill works as expected on

---------

Co-authored-by: dbajpeyi <[email protected]>
Co-authored-by: Craig Russell <[email protected]>
Co-authored-by: Deepankar Bajpeyi <[email protected]>

Author: 3 people

autofill/autofill-api/src/main/java/com/duckduckgo/autofill/api/AutofillFeature.kt

@@ -75,6 +75,13 @@ interface AutofillFeature {
     @Toggle.DefaultValue(DefaultFeatureValue.FALSE)
     fun canCategorizeUnknownUsername(): Toggle
 
+    /**
+     * @return `true` when the remote config has "passwordVariantCategorization" autofill sub-feature flag enabled
+     * If the remote feature is not present defaults to `false`
+     */
+    @Toggle.DefaultValue(DefaultFeatureValue.FALSE)
+    fun passwordVariantCategorization(): Toggle
+
     /**
      * @return `true` when the remote config has the global "onByDefault" autofill sub-feature flag enabled
      * If the remote feature is not present defaults to `false`

autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/configuration/AutofillRuntimeConfigProvider.kt

@@ -64,8 +64,11 @@ class RealAutofillRuntimeConfigProvider @Inject constructor(
             showInlineKeyIcon = true,
             showInContextEmailProtectionSignup = canShowInContextEmailProtectionSignup(url),
             unknownUsernameCategorization = canCategorizeUnknownUsername(),
+            canCategorizePasswordVariant = canCategorizePasswordVariant(),
             partialFormSaves = partialFormSaves(),
-        )
+        ).also {
+            Timber.v("autofill-config: userPreferences for %s: \n%s", url, it)
+        }
         val availableInputTypes = generateAvailableInputTypes(url)
 
         return StringBuilder(rawJs).apply {
@@ -88,7 +91,7 @@ class RealAutofillRuntimeConfigProvider @Inject constructor(
         val emailAvailable = determineIfEmailAvailable()
 
         val json = runtimeConfigurationWriter.generateResponseGetAvailableInputTypes(credentialsAvailable, emailAvailable).also {
-            Timber.v("availableInputTypes for %s: \n%s", url, it)
+            Timber.v("autofill-config: availableInputTypes for %s: \n%s", url, it)
         }
         return "availableInputTypes = $json"
     }
@@ -143,6 +146,10 @@ class RealAutofillRuntimeConfigProvider @Inject constructor(
         return autofillFeature.canCategorizeUnknownUsername().isEnabled()
     }
 
+    private fun canCategorizePasswordVariant(): Boolean {
+        return autofillFeature.passwordVariantCategorization().isEnabled()
+    }
+
     private fun partialFormSaves(): Boolean {
         return autofillFeature.partialFormSaves().isEnabled()
     }

autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/configuration/RuntimeConfigurationWriter.kt

@@ -39,6 +39,7 @@ interface RuntimeConfigurationWriter {
         showInlineKeyIcon: Boolean,
         showInContextEmailProtectionSignup: Boolean,
         unknownUsernameCategorization: Boolean,
+        canCategorizePasswordVariant: Boolean,
         partialFormSaves: Boolean,
     ): String
 }
@@ -102,6 +103,7 @@ class RealRuntimeConfigurationWriter @Inject constructor(val moshi: Moshi) : Run
         showInlineKeyIcon: Boolean,
         showInContextEmailProtectionSignup: Boolean,
         unknownUsernameCategorization: Boolean,
+        canCategorizePasswordVariant: Boolean,
         partialFormSaves: Boolean,
     ): String {
         return """
@@ -123,7 +125,8 @@ class RealRuntimeConfigurationWriter @Inject constructor(val moshi: Moshi) : Run
                       "inlineIcon_credentials": $showInlineKeyIcon,
                       "emailProtection_incontext_signup": $showInContextEmailProtectionSignup,
                       "unknown_username_categorization": $unknownUsernameCategorization,
-                      "partial_form_saves": $partialFormSaves
+                      "partial_form_saves": $partialFormSaves,
+                      "password_variant_categorization" : $canCategorizePasswordVariant
                     }
                   }
                 }

autofill/autofill-impl/src/test/java/com/duckduckgo/autofill/impl/configuration/RealAutofillRuntimeConfigProviderTest.kt

@@ -16,6 +16,7 @@
 
 package com.duckduckgo.autofill.impl.configuration
 
+import android.annotation.SuppressLint
 import androidx.test.ext.junit.runners.AndroidJUnit4
 import com.duckduckgo.autofill.api.AutofillCapabilityChecker
 import com.duckduckgo.autofill.api.AutofillFeature
@@ -39,6 +40,7 @@ import org.mockito.kotlin.mock
 import org.mockito.kotlin.verify
 import org.mockito.kotlin.whenever
 
+@SuppressLint("DenyListedApi")
 @RunWith(AndroidJUnit4::class)
 class RealAutofillRuntimeConfigProviderTest {
 
@@ -93,6 +95,7 @@ class RealAutofillRuntimeConfigProviderTest {
                 showInlineKeyIcon = any(),
                 showInContextEmailProtectionSignup = any(),
                 unknownUsernameCategorization = any(),
+                canCategorizePasswordVariant = any(),
                 partialFormSaves = any(),
             ),
         ).thenReturn("")
@@ -122,6 +125,22 @@ class RealAutofillRuntimeConfigProviderTest {
         verifyKeyIconRequestedToShow()
     }
 
+    @Test
+    fun whenCanCategorizePasswordVariantEnabledThenConfigurationUserPrefsReflectsThat() = runTest {
+        configureAutofillCapabilities(enabled = false)
+        autofillFeature.passwordVariantCategorization().setRawStoredState(State(enable = true))
+        testee.getRuntimeConfiguration("", EXAMPLE_URL)
+        verifyCanCategorizePasswordVariant(true)
+    }
+
+    @Test
+    fun whenCanCategorizePasswordVariantDisabledThenConfigurationUserPrefsReflectsThat() = runTest {
+        configureAutofillCapabilities(enabled = false)
+        autofillFeature.passwordVariantCategorization().setRawStoredState(State(enable = false))
+        testee.getRuntimeConfiguration("", EXAMPLE_URL)
+        verifyCanCategorizePasswordVariant(false)
+    }
+
     @Test
     fun whenNoCredentialsForUrlThenConfigurationInputTypeCredentialsIsFalse() = runTest {
         configureAutofillEnabledWithNoSavedCredentials(EXAMPLE_URL)
@@ -404,6 +423,7 @@ class RealAutofillRuntimeConfigProviderTest {
             showInlineKeyIcon = any(),
             showInContextEmailProtectionSignup = any(),
             unknownUsernameCategorization = any(),
+            canCategorizePasswordVariant = any(),
             partialFormSaves = any(),
         )
     }
@@ -416,6 +436,20 @@ class RealAutofillRuntimeConfigProviderTest {
             showInlineKeyIcon = any(),
             showInContextEmailProtectionSignup = any(),
             unknownUsernameCategorization = any(),
+            canCategorizePasswordVariant = any(),
+            partialFormSaves = any(),
+        )
+    }
+
+    private fun verifyCanCategorizePasswordVariant(expected: Boolean) {
+        verify(runtimeConfigurationWriter).generateUserPreferences(
+            autofillCredentials = any(),
+            credentialSaving = any(),
+            passwordGeneration = any(),
+            showInlineKeyIcon = any(),
+            showInContextEmailProtectionSignup = any(),
+            unknownUsernameCategorization = any(),
+            canCategorizePasswordVariant = eq(expected),
             partialFormSaves = any(),
         )
     }
@@ -432,6 +466,7 @@ class RealAutofillRuntimeConfigProviderTest {
             showInlineKeyIcon = eq(true),
             showInContextEmailProtectionSignup = any(),
             unknownUsernameCategorization = any(),
+            canCategorizePasswordVariant = any(),
             partialFormSaves = any(),
         )
     }

autofill/autofill-impl/src/test/java/com/duckduckgo/autofill/impl/configuration/RealRuntimeConfigurationWriterTest.kt

@@ -139,7 +139,8 @@ class RealRuntimeConfigurationWriterTest {
                       "inlineIcon_credentials": true,
                       "emailProtection_incontext_signup": true,
                       "unknown_username_categorization": false,
-                      "partial_form_saves": false
+                      "partial_form_saves": false,
+                      "password_variant_categorization" : false
                     }
                   }
                 }
@@ -155,6 +156,7 @@ class RealRuntimeConfigurationWriterTest {
                 showInlineKeyIcon = true,
                 showInContextEmailProtectionSignup = true,
                 unknownUsernameCategorization = false,
+                canCategorizePasswordVariant = false,
                 partialFormSaves = false,
             ),
         )