Fix: nav history not cleared when favorite clicked (#1285)

* Fix: nav history not cleared when favorite clicked

* remove unused command

Author: cmonfortep

app/src/androidTest/java/com/duckduckgo/app/browser/BrowserTabViewModelTest.kt

@@ -570,17 +570,6 @@ class BrowserTabViewModelTest {
         verify(mockFavoritesRepository, times(0)).insert(any(), any())
     }
 
-    @Test
-    fun whenQuickAccessItemClickedThenSubmitNewQuery() {
-        val savedSite = Favorite(1, "title", "http://example.com", 0)
-
-        testee.onQuickAccesItemClicked(savedSite)
-
-        assertCommandIssued<Command.SubmitQuery> {
-            assertEquals("http://example.com", this.url)
-        }
-    }
-
     @Test
     fun whenQuickAccessDeletedThenRepositoryUpdated() = coroutineRule.runBlocking {
         val savedSite = Favorite(1, "title", "http://example.com", 0)

app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt

@@ -656,7 +656,6 @@ class BrowserTabFragment :
             is Command.ConvertBlobToDataUri -> convertBlobToDataUri(it)
             is Command.RequestFileDownload -> requestFileDownload(it.url, it.contentDisposition, it.mimeType, it.requestUserConfirmation)
             is Command.ChildTabClosed -> processUriForThirdPartyCookies()
-            is Command.SubmitQuery -> submitQuery(it.url)
             is Command.CopyAliasToClipboard -> copyAliasToClipboard(it.alias)
             is Command.InjectEmailAddress -> injectEmailAddress(it.address)
             is Command.ShowEmailTooltip -> showEmailTooltip(it.address)
@@ -1033,7 +1032,7 @@ class BrowserTabFragment :
     private fun createQuickAccessAdapter(onMoveListener: (RecyclerView.ViewHolder) -> Unit): FavoritesQuickAccessAdapter {
         return FavoritesQuickAccessAdapter(
             this, faviconManager, onMoveListener,
-            { viewModel.onQuickAccesItemClicked(it.favorite) },
+            { viewModel.onUserSubmittedQuery(it.favorite.url) },
             { viewModel.onEditSavedSiteRequested(it.favorite) },
             { viewModel.onDeleteQuickAccessItemRequested(it.favorite) }
         )

app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt

@@ -277,7 +277,6 @@ class BrowserTabViewModel(
         class AskToFireproofWebsite(val fireproofWebsite: FireproofWebsiteEntity) : Command()
         class ShareLink(val url: String) : Command()
         class CopyLink(val url: String) : Command()
-        class SubmitQuery(val url: String) : Command()
         class FindInPageCommand(val searchTerm: String) : Command()
         class BrokenSiteFeedback(val data: BrokenSiteData) : Command()
         object DismissFindInPage : Command()
@@ -1945,10 +1944,6 @@ class BrowserTabViewModel(
         }
     }
 
-    fun onQuickAccesItemClicked(it: SavedSite) {
-        command.value = SubmitQuery(it.url)
-    }
-
     fun deleteQuickAccessItem(savedSite: SavedSite) {
         val favorite = savedSite as? SavedSite.Favorite ?: return
         viewModelScope.launch(dispatchers.io() + NonCancellable) {