Skip to content

Commit 12fa775

Browse files
authored
Feature/remove tracker blocker opt in experiment (#493)
* Code tidy * Remove experimental variant for tracker blocker opt-in * Restore tracker blocker opt-in experiments with 0-weighting
1 parent 615d752 commit 12fa775

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

app/src/main/java/com/duckduckgo/app/onboarding/ui/OnboardingViewModel.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ class OnboardingViewModel(
4646
fun onOnboardingDone() {
4747
onboardingStore.onboardingShown()
4848
fireTrackerBlockingFinalStatePixel()
49-
5049
}
5150

5251
private fun fireTrackerBlockingFinalStatePixel() {
@@ -59,4 +58,4 @@ class OnboardingViewModel(
5958
pixel.fire(pixelName)
6059
}
6160
}
62-
}
61+
}

app/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,8 @@ interface VariantManager {
5353
Variant(key = "mk", weight = 0.0, features = listOf(NotificationPrivacyDay1)),
5454

5555
// tracker blocker opt in variants
56-
Variant(key = "mm", weight = 1.0, features = emptyList()),
57-
Variant(key = "mn", weight = 1.0, features = listOf(TrackerBlockingOnboardingOptIn))
56+
Variant(key = "mm", weight = 0.0, features = emptyList()),
57+
Variant(key = "mn", weight = 0.0, features = listOf(TrackerBlockingOnboardingOptIn))
5858
)
5959
}
6060

@@ -104,6 +104,7 @@ class ExperimentationVariantManager(
104104
private fun generateVariant(activeVariants: List<Variant>): Variant {
105105
val weightSum = activeVariants.sumByDouble { it.weight }
106106
if (weightSum == 0.0) {
107+
Timber.v("No variants active; allocating default")
107108
return DEFAULT_VARIANT
108109
}
109110
val randomizedIndex = indexRandomizer.random(activeVariants)

0 commit comments

Comments
 (0)