Skip to content

Commit 1b00329

Browse files
committed
Add support for willThrow query param
1 parent b265a87 commit 1b00329

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

app/src/main/java/com/duckduckgo/app/pixels/AppPixelName.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -408,6 +408,7 @@ enum class AppPixelName(override val pixelName: String) : Pixel.PixelName {
408408
DUCK_PLAYER_YOUTUBE_ERROR_AGE_RESTRICTED_DAILY_UNIQUE("duckplayer_youtube-age-restricted-error_daily-unique"),
409409
DUCK_PLAYER_YOUTUBE_ERROR_NO_EMBED_DAILY_UNIQUE("duckplayer_youtube-no-embed-error_daily-unique"),
410410
DUCK_PLAYER_YOUTUBE_ERROR_UNKNOWN_DAILY_UNIQUE("duckplayer_youtube-unknown-error_daily-unique"),
411+
DUCK_PLAYER_JS_ERROR("duckplayer_js-error"),
411412

412413
MALICIOUS_SITE_PROTECTION_SETTING_TOGGLED("m_malicious-site-protection_feature-toggled"),
413414
MALICIOUS_SITE_PROTECTION_VISIT_SITE("m_malicious-site-protection_visit-site"),

duckplayer/duckplayer-impl/src/main/java/com/duckduckgo/duckplayer/impl/RealDuckPlayer.kt

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,11 @@ class RealDuckPlayer @Inject constructor(
212212
if (!isFeatureEnabled) return null
213213
val embedUrl = duckPlayerFeatureRepository.getYouTubeEmbedUrl()
214214
uri.pathSegments?.firstOrNull()?.let { videoID ->
215-
return "$https://www.$embedUrl?$DUCK_PLAYER_VIDEO_ID_QUERY_PARAM=$videoID"
215+
return "$https://www.$embedUrl?$DUCK_PLAYER_VIDEO_ID_QUERY_PARAM=$videoID".let {
216+
uri.getQueryParameter("willThrow")?.takeIf { it.isNotBlank() }?.let { willThrow ->
217+
"$it&willThrow=$willThrow"
218+
} ?: it
219+
}
216220
}
217221
return null
218222
}

0 commit comments

Comments
 (0)