FF updating script on protections changed (#6906)

Task/Issue URL:
https://app.asana.com/1/137249556945/project/72649045549333/task/1211578851788392?focus=true

### Description
* FF updating script on protections changed as part of native crashes
investigation after adding `addDocumentStartJavaScript`

### Steps to test this PR

_Pre-requisites_
- [x] Apply this
[patch](https://duckduckgo-my.sharepoint.com/:u:/p/cbarreiro/EfoKD1EMQPxFhWiH_LHI2wgB0RxCvVUtJBiCx7ofwCsTeQ?e=Lhx8IW)
- [x] Do a clean install of the app
- [x] Open Feature flags inventory
- [x] Set `updateScriptOnPageFinished` to false to reduce the amount of
logs
- [x] Filter logcat by `"Cris"`


_FF enabled_
- [x] Open Feature flags inventory
- [x] Set `updateScriptOnProtectionsChanged` to true
- [x] Load a page
- [x] Change protection status from context menu
- [x] Check there's a log for `addDocumentJavaScript` every time you
toggle protections
- [x] Open privacy dashboard and toggle privacy protections from there
- [x] Navigate back to the WebView
- [x] Check there's a log for `addDocumentJavaScript` every time you
toggle protections

_FF enabled_
- [x] Open Feature flags inventory
- [x] Set `updateScriptOnProtectionsChanged` to false
- [x] Load a page
- [x] Change protection status from context menu
- [x] Check there's no log for `addDocumentJavaScript` every time you
toggle protections
- [x] Open privacy dashboard and toggle privacy protections from there
- [x] Navigate back to the WebView
- [x] Check there's no log for `addDocumentJavaScript` every time you
toggle protections

### UI changes
n/a

Author: CrisBarreiro

app/src/androidTest/java/com/duckduckgo/app/browser/BrowserTabViewModelTest.kt

@@ -7005,9 +7005,10 @@ class BrowserTabViewModelTest {
         }
 
     @Test
-    fun whenPrivacyProtectionsUpdatedAndAndUpdateScriptOnPageFinishedEnabledThenAddDocumentStartJavaScript() =
+    fun whenPrivacyProtectionsUpdatedAndUpdateScriptOnPageFinishedEnabledAndUpdateScriptOnProtectionsChangedEnabledThenAddDocumentStartJavaScript() =
         runTest {
             fakeAndroidConfigBrowserFeature.updateScriptOnPageFinished().setRawStoredState(State(true))
+            fakeAndroidConfigBrowserFeature.updateScriptOnProtectionsChanged().setRawStoredState(State(true))
 
             testee.privacyProtectionsUpdated(mockWebView)
 
@@ -7016,16 +7017,41 @@ class BrowserTabViewModelTest {
         }
 
     @Test
-    fun whenPrivacyProtectionsUpdatedAndAndUpdateScriptOnPageFinishedDisabledThenAddDocumentStartJavaScriptOnlyOnCSS() =
+    fun whenPrivacyProtectionsUpdatedAndUpdateScriptOnPageFinishedTrueAndUpdateScriptOnProtectionsChangedFalseThenNotAddDocumentStartJavaScript() =
+        runTest {
+            fakeAndroidConfigBrowserFeature.updateScriptOnPageFinished().setRawStoredState(State(true))
+            fakeAndroidConfigBrowserFeature.updateScriptOnProtectionsChanged().setRawStoredState(State(false))
+
+            testee.privacyProtectionsUpdated(mockWebView)
+
+            assertEquals(0, fakeAddDocumentStartJavaScriptPlugins.cssPlugin.countInitted)
+            assertEquals(0, fakeAddDocumentStartJavaScriptPlugins.otherPlugin.countInitted)
+        }
+
+    @Test
+    fun whenPrivacyProtectionsUpdatedAndUpdateScriptOnPageFinishedDisabledThenAddDocumentStartJavaScriptOnlyOnCSS() =
         runTest {
             fakeAndroidConfigBrowserFeature.updateScriptOnPageFinished().setRawStoredState(State(false))
+            fakeAndroidConfigBrowserFeature.updateScriptOnProtectionsChanged().setRawStoredState(State(true))
 
             testee.privacyProtectionsUpdated(mockWebView)
 
             assertEquals(1, fakeAddDocumentStartJavaScriptPlugins.cssPlugin.countInitted)
             assertEquals(0, fakeAddDocumentStartJavaScriptPlugins.otherPlugin.countInitted)
         }
 
+    @Test
+    fun whenPrivacyProtectionsUpdatedAndUpdateScriptOnPageFinishedFalseAndUpdateScriptOnProtectionsChangedFalseThenNotAddDocumentStartJavaScript() =
+        runTest {
+            fakeAndroidConfigBrowserFeature.updateScriptOnPageFinished().setRawStoredState(State(false))
+            fakeAndroidConfigBrowserFeature.updateScriptOnProtectionsChanged().setRawStoredState(State(false))
+
+            testee.privacyProtectionsUpdated(mockWebView)
+
+            assertEquals(0, fakeAddDocumentStartJavaScriptPlugins.cssPlugin.countInitted)
+            assertEquals(0, fakeAddDocumentStartJavaScriptPlugins.otherPlugin.countInitted)
+        }
+
     @Test
     fun whenCtaShownThenFireInContextDialogShownPixel() =
         runTest {

app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt

@@ -4257,6 +4257,10 @@ class BrowserTabViewModel @Inject constructor(
     }
 
     suspend fun privacyProtectionsUpdated(webView: WebView) {
+        if (withContext(dispatchers.io()) { !androidBrowserConfig.updateScriptOnProtectionsChanged().isEnabled() }) {
+            return
+        }
+
         if (withContext(dispatchers.io()) { !androidBrowserConfig.updateScriptOnPageFinished().isEnabled() }) {
             addDocumentStartJavascriptPlugins
                 .getPlugins()

app/src/main/java/com/duckduckgo/app/pixels/remoteconfig/AndroidBrowserConfigFeature.kt

@@ -191,4 +191,7 @@ interface AndroidBrowserConfigFeature {
 
     @Toggle.DefaultValue(TRUE)
     fun updateScriptOnPageFinished(): Toggle
+
+    @Toggle.DefaultValue(TRUE)
+    fun updateScriptOnProtectionsChanged(): Toggle
 }