Fix: Broken snackbar Undo button (#6781)

Task/Issue URL:
https://app.asana.com/1/137249556945/project/1207418217763355/task/1211316645347512?focus=true

### Description

This PR fixes an issue when the snackbar was position behind a
RecyclerView and the snackbar was not clickable.

### Steps to test this PR

_Undo button (top omnibar)_
- [ ] Generate a lot of tabs (in developer settings)
- [ ] Go to the tab switcher
- [ ] Close some tab
- [ ] Verify a snackbar appears at the bottom of the screen, above the
tabs
- [ ] Tap on the Undo button
- [ ] Verify the deleted tab is restored

_Undo button (bottom omnibar)_
- [ ] Change the omnibar position to the bottom
- [ ] Go to the tab switcher
- [ ] Close some tab
- [ ] Verify a snackbar appears at the bottom, above the toolbar
- [ ] Tap on the Undo button
- [ ] Verify the deleted tab is restored

Author: 0nko

app/src/main/res/layout/activity_browser.xml

@@ -25,7 +25,7 @@
     <include
         android:id="@+id/topMockupSingleToolbar"
         android:layout_width="match_parent"
-        android:layout_height="@dimen/toolbarSize"
+        android:layout_height="?attr/actionBarSize"
         android:layout_alignParentTop="true"
         layout="@layout/include_omnibar_toolbar_mockup" />
 
@@ -56,7 +56,7 @@
     <include
         android:id="@+id/bottomMockupSingleToolbar"
         android:layout_width="match_parent"
-        android:layout_height="@dimen/toolbarSize"
+        android:layout_height="?attr/actionBarSize"
         android:layout_alignParentBottom="true"
         layout="@layout/include_omnibar_toolbar_mockup_bottom" />
 

app/src/main/res/layout/activity_tab_switcher.xml

@@ -37,7 +37,6 @@
         android:id="@+id/tabsContainer"
         android:layout_width="match_parent"
         android:layout_height="match_parent"
-        android:elevation="10dp"
         app:layout_behavior="@string/appbar_scrolling_view_behavior">
 
         <View

app/src/main/res/layout/include_find_in_page.xml

@@ -24,7 +24,7 @@
     android:orientation="horizontal"
     android:paddingHorizontal="2dp"
     tools:ignore="KeyboardInaccessibleWidget"
-    tools:layout_height="@dimen/toolbarSize">
+    tools:layout_height="?attr/actionBarSize">
 
     <!-- The expected horizontal padding for content is 6dp but we're applying only 2dp
     because the remaining 4dp are added by the omnibar selection animation -->

app/src/main/res/layout/include_omnibar_toolbar_mockup.xml

@@ -21,7 +21,7 @@
     xmlns:tools="http://schemas.android.com/tools"
     android:id="@+id/appBarLayoutMockup"
     android:layout_width="match_parent"
-    android:layout_height="@dimen/toolbarSize"
+    android:layout_height="?attr/actionBarSize"
     android:background="?daxColorToolbar"
     android:clipChildren="false">
 

app/src/main/res/layout/include_omnibar_toolbar_mockup_bottom.xml

@@ -21,7 +21,7 @@
     xmlns:tools="http://schemas.android.com/tools"
     android:id="@+id/appBarLayoutMockup"
     android:layout_width="match_parent"
-    android:layout_height="@dimen/toolbarSize"
+    android:layout_height="?attr/actionBarSize"
     android:background="?daxColorToolbar"
     android:clipChildren="false">
 

app/src/main/res/layout/view_single_omnibar.xml

@@ -41,7 +41,7 @@
             <androidx.appcompat.widget.Toolbar
                 android:id="@+id/toolbar"
                 android:layout_width="0dp"
-                android:layout_height="@dimen/toolbarSize"
+                android:layout_height="?attr/actionBarSize"
                 android:clipChildren="false"
                 app:contentInsetEnd="0dp"
                 app:contentInsetStart="0dp"
@@ -364,7 +364,7 @@
             <androidx.constraintlayout.widget.ConstraintLayout
                 android:id="@+id/customTabToolbarContainerWrapper"
                 android:layout_width="0dp"
-                android:layout_height="@dimen/toolbarSize"
+                android:layout_height="?attr/actionBarSize"
                 android:layout_marginHorizontal="@dimen/keyline_2"
                 app:layout_constraintBottom_toBottomOf="parent"
                 app:layout_constraintEnd_toStartOf="@id/iconsContainer"

common/common-ui/src/main/res/layout/include_tab_switcher_toolbar_bottom.xml

@@ -25,12 +25,16 @@
     android:elevation="0dp"
     android:outlineProvider="none">
 
+    <View
+        android:layout_width="match_parent"
+        android:layout_height="0.5dp"
+        android:background="?attr/daxColorShadeSolid" />
+
     <androidx.appcompat.widget.Toolbar
         android:id="@+id/toolbar"
         android:layout_width="match_parent"
         android:layout_height="?attr/actionBarSize"
         android:background="?attr/daxColorToolbar"
-        android:paddingTop="?attr/toolbarExtraPadding"
         android:theme="@style/TabSwitcher.Widget.Toolbar"
         app:popupTheme="@style/Widget.DuckDuckGo.PopUpOverflowMenu" />
 

common/common-ui/src/main/res/layout/include_tab_switcher_toolbar_top.xml

@@ -28,10 +28,14 @@
     <androidx.appcompat.widget.Toolbar
         android:id="@+id/toolbar"
         android:layout_width="match_parent"
-        android:layout_height="@dimen/tabSwitcherToolbarTopSize"
-        android:paddingBottom="?attr/toolbarExtraPadding"
+        android:layout_height="?attr/actionBarSize"
         android:background="?attr/daxColorToolbar"
         android:theme="@style/TabSwitcher.Widget.Toolbar"
         app:popupTheme="@style/Widget.DuckDuckGo.PopUpOverflowMenu" />
 
+    <View
+        android:layout_width="match_parent"
+        android:layout_height="0.5dp"
+        android:background="?attr/daxColorShade" />
+
 </com.google.android.material.appbar.AppBarLayout>

common/common-ui/src/main/res/values/design-system-attrs.xml

@@ -29,6 +29,4 @@
     <attr name="cookiesAnimationRadius" format="dimension"/>
     <attr name="cookiesAnimationHeight" format="dimension"/>
 
-    <attr name="toolbarExtraPadding" format="dimension"/>
-
 </resources>

common/common-ui/src/main/res/values/design-system-dimensions.xml

@@ -43,7 +43,6 @@
     <dimen name="toolbarIconPadding">3dp</dimen>
     <dimen name="toolbarIcon">40dp</dimen>
     <dimen name="toolbarSize">60dp</dimen>
-    <dimen name="tabSwitcherToolbarTopSize">56dp</dimen>
 
     <!-- Navigation Bar -->
     <dimen name="experimentalNavigationBarPaddingTopWhenStandalone">12dp</dimen>