Skip to content

Commit 240b6aa

Browse files
authored
Allow omnibar queries to be submitted with the "enter" key
Previously a user needed to tap the done button to submit a query. Pressing enter on a keyboard (as may happen when debugging on an emulator) did not work
1 parent 2195d01 commit 240b6aa

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

app/src/main/java/com/duckduckgo/app/browser/BrowserActivity.kt

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,11 @@ import android.content.Context
2323
import android.content.Intent
2424
import android.os.Bundle
2525
import android.text.Editable
26+
import android.view.KeyEvent.KEYCODE_ENTER
2627
import android.view.Menu
2728
import android.view.MenuItem
2829
import android.view.View
29-
import android.view.inputmethod.EditorInfo
30+
import android.view.inputmethod.EditorInfo.IME_ACTION_DONE
3031
import android.webkit.WebSettings.MIXED_CONTENT_COMPATIBILITY_MODE
3132
import android.widget.TextView
3233
import com.duckduckgo.app.browser.BrowserViewModel.NavigationCommand.LANDING_PAGE
@@ -183,8 +184,8 @@ class BrowserActivity : DuckDuckGoActivity() {
183184

184185
viewModel.registerWebViewListener(webViewClient, webChromeClient)
185186

186-
urlInput.setOnEditorActionListener(TextView.OnEditorActionListener { _, actionId, _ ->
187-
if (actionId == EditorInfo.IME_ACTION_DONE) {
187+
urlInput.setOnEditorActionListener(TextView.OnEditorActionListener { _, actionId, keyEvent ->
188+
if (actionId == IME_ACTION_DONE || keyEvent.keyCode == KEYCODE_ENTER) {
188189
userEnteredQuery()
189190
return@OnEditorActionListener true
190191
}

0 commit comments

Comments
 (0)