Skip to content

Commit 2be80bc

Browse files
committed
Remove unused param
1 parent 93a68e8 commit 2be80bc

File tree

2 files changed

+0
-17
lines changed

2 files changed

+0
-17
lines changed

js-messaging/js-messaging-impl/src/main/java/com/duckduckgo/js/messaging/impl/RealWebMessagingDelegate.kt

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,7 @@ import androidx.annotation.VisibleForTesting
2222
import androidx.lifecycle.findViewTreeLifecycleOwner
2323
import androidx.lifecycle.lifecycleScope
2424
import androidx.webkit.JavaScriptReplyProxy
25-
import com.duckduckgo.app.di.AppCoroutineScope
2625
import com.duckduckgo.browser.api.webviewcompat.WebViewCompatWrapper
27-
import com.duckduckgo.common.utils.DispatcherProvider
2826
import com.duckduckgo.di.scopes.AppScope
2927
import com.duckduckgo.js.messaging.api.JsCallbackData
3028
import com.duckduckgo.js.messaging.api.JsMessage
@@ -38,7 +36,6 @@ import com.duckduckgo.js.messaging.api.WebMessagingStrategy
3836
import com.duckduckgo.js.messaging.api.WebViewCompatMessageCallback
3937
import com.squareup.anvil.annotations.ContributesBinding
4038
import com.squareup.moshi.Moshi
41-
import kotlinx.coroutines.CoroutineScope
4239
import kotlinx.coroutines.launch
4340
import logcat.LogPriority.ERROR
4441
import logcat.asLog
@@ -49,8 +46,6 @@ import javax.inject.Inject
4946
@ContributesBinding(AppScope::class)
5047
class RealWebMessagingDelegate @Inject constructor(
5148
private val webViewCompatWrapper: WebViewCompatWrapper,
52-
private val dispatcherProvider: DispatcherProvider,
53-
@AppCoroutineScope private val appCoroutineScope: CoroutineScope,
5449
) : WebMessagingDelegate {
5550
override fun createPlugin(strategy: WebMessagingStrategy): WebMessaging {
5651
return object : WebMessaging {

js-messaging/js-messaging-impl/src/test/java/com/duckduckgo/js/messaging/impl/RealWebMessagingDelegateTest.kt

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@ import androidx.webkit.JavaScriptReplyProxy
2222
import androidx.webkit.WebMessageCompat
2323
import androidx.webkit.WebViewCompat.WebMessageListener
2424
import com.duckduckgo.browser.api.webviewcompat.WebViewCompatWrapper
25-
import com.duckduckgo.common.test.CoroutineTestRule
26-
import com.duckduckgo.common.utils.DispatcherProvider
2725
import com.duckduckgo.js.messaging.api.GlobalJsMessageHandler
2826
import com.duckduckgo.js.messaging.api.JsMessage
2927
import com.duckduckgo.js.messaging.api.ProcessResult
@@ -35,7 +33,6 @@ import com.duckduckgo.js.messaging.api.WebViewCompatMessageHandler
3533
import kotlinx.coroutines.test.runTest
3634
import org.json.JSONObject
3735
import org.junit.Before
38-
import org.junit.Rule
3936
import org.junit.Test
4037
import org.junit.runner.RunWith
4138
import org.mockito.ArgumentMatchers.anyString
@@ -45,30 +42,21 @@ import org.mockito.kotlin.eq
4542
import org.mockito.kotlin.mock
4643
import org.mockito.kotlin.never
4744
import org.mockito.kotlin.verify
48-
import org.mockito.kotlin.whenever
4945

5046
@RunWith(AndroidJUnit4::class)
5147
class RealWebMessagingDelegateTest {
52-
53-
@get:Rule
54-
val coroutineRule = CoroutineTestRule()
55-
5648
private val mockWebViewCompatWrapper: WebViewCompatWrapper = mock()
5749
private val mockWebView: WebView = mock()
5850
private val mockReplyProxy: JavaScriptReplyProxy = mock()
59-
private val mockDispatcherProvider: DispatcherProvider = mock()
6051
private val mockWebViewCompatMessageCallback: WebViewCompatMessageCallback = mock()
6152

6253
private lateinit var testee: RealWebMessagingDelegate
6354
private lateinit var plugin: WebMessaging
6455

6556
@Before
6657
fun setUp() = runTest {
67-
whenever(mockDispatcherProvider.main()).thenReturn(coroutineRule.testDispatcher)
6858
testee = RealWebMessagingDelegate(
6959
webViewCompatWrapper = mockWebViewCompatWrapper,
70-
dispatcherProvider = mockDispatcherProvider,
71-
appCoroutineScope = coroutineRule.testScope,
7260
)
7361
}
7462

0 commit comments

Comments
 (0)