Fix omnibar-related Maestro tests (#5974)

joshliebe · web-flow · commit 329b53ba7b80 · 2025-04-28T22:28:03.000+01:00
Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1210096722341717?focus=true ### Description - Changes omnibar-related tests to use `id` instead of `text` when asserting on the hint. - Adds a test to check that the hint is “Search” on new tab and "Search or Type URL” on an open tab. ### Steps to test this PR - [ ] Code review
diff --git a/.maestro/autofill/backfillingUsername/multi_step_login_username_backfilled.yaml b/.maestro/autofill/backfillingUsername/multi_step_login_username_backfilled.yaml
@@ -15,7 +15,7 @@ tags:
 
       # get to autofill form
       - tapOn:
-          text: "search or type URL"
+          id: "omnibarTextInput"
       - inputText: "https://autofill.me/form/login-simple"
       - pressKey: Enter
 
diff --git a/.maestro/autofill/backfillingUsername/multi_step_login_username_backfilled_for_an_update.yaml b/.maestro/autofill/backfillingUsername/multi_step_login_username_backfilled_for_an_update.yaml
@@ -18,7 +18,7 @@ tags:
 
       # get to autofill form
       - tapOn:
-          text: "search or type URL"
+          id: "omnibarTextInput"
       - inputText: "https://autofill.me/form/login-simple"
       - pressKey: Enter
       - runFlow: ../steps/decline_autofill_prompt.yaml
diff --git a/.maestro/autofill/backfillingUsername/multi_step_login_username_not_backfilled_if_provided_explicitly.yaml b/.maestro/autofill/backfillingUsername/multi_step_login_username_not_backfilled_if_provided_explicitly.yaml
@@ -15,7 +15,7 @@ tags:
 
       # get to autofill form
       - tapOn:
-          text: "search or type URL"
+          id: "omnibarTextInput"
       - inputText: "https://autofill.me/form/login-simple"
       - pressKey: Enter
 
diff --git a/.maestro/autofill/backfillingUsername/multi_step_registration_username_backfilled_password_autogenerated.yaml b/.maestro/autofill/backfillingUsername/multi_step_registration_username_backfilled_password_autogenerated.yaml
@@ -15,7 +15,7 @@ tags:
 
       # get to autofill form
       - tapOn:
-          text: "search or type URL"
+          id: "omnibarTextInput"
       - inputText: "https://autofill.me/form/registration-username"
       - pressKey: Enter
 
diff --git a/.maestro/autofill/backfillingUsername/multi_step_registration_username_backfilled_password_manually_entered.yaml b/.maestro/autofill/backfillingUsername/multi_step_registration_username_backfilled_password_manually_entered.yaml
@@ -15,7 +15,7 @@ tags:
 
       # get to autofill form
       - tapOn:
-          text: "search or type URL"
+          id: "omnibarTextInput"
       - inputText: "https://autofill.me/form/registration-username"
       - pressKey: Enter
 
diff --git a/.maestro/autofill/backfillingUsername/password_reset_flow_autogenerated_password.yaml b/.maestro/autofill/backfillingUsername/password_reset_flow_autogenerated_password.yaml
@@ -15,7 +15,7 @@ tags:
 
       # get to autofill login form
       - tapOn:
-          text: "search or type URL"
+          id: "omnibarTextInput"
       - inputText: "https://autofill.me/form/login-simple"
       - pressKey: Enter
 
diff --git a/.maestro/autofill/backfillingUsername/password_reset_flow_for_existing_credential_generated_password.yaml b/.maestro/autofill/backfillingUsername/password_reset_flow_for_existing_credential_generated_password.yaml
@@ -15,7 +15,7 @@ tags:
 
       # get to autofill login form
       - tapOn:
-          text: "search or type URL"
+          id: "omnibarTextInput"
       - inputText: "https://autofill.me/form/login-simple"
       - pressKey: Enter
 
diff --git a/.maestro/autofill/passwordGeneration/autosaves_credential_when_password_generated_with_username.yaml b/.maestro/autofill/passwordGeneration/autosaves_credential_when_password_generated_with_username.yaml
@@ -15,7 +15,7 @@ tags:
 
       # get to autofill form
       - tapOn:
-          text: "search or type URL"
+          id: "omnibarTextInput"
       - inputText: "https://autofill.me/form/registration-username"
       - pressKey: Enter
 
diff --git a/.maestro/autofill/passwordGeneration/autosaves_credential_when_password_generated_without_username.yaml b/.maestro/autofill/passwordGeneration/autosaves_credential_when_password_generated_without_username.yaml
@@ -15,7 +15,7 @@ tags:
 
       # get to autofill form
       - tapOn:
-          text: "search or type URL"
+          id: "omnibarTextInput"
       - inputText: "https://autofill.me/form/registration-username"
       - pressKey: Enter
 
diff --git a/.maestro/bookmarks/ensure_bookmarks_can_be_added_and_deleted.yaml b/.maestro/bookmarks/ensure_bookmarks_can_be_added_and_deleted.yaml
@@ -13,7 +13,7 @@ tags:
       - runFlow: ../shared/skip_all_onboarding.yaml
 
       - tapOn:
-          text: "search or type URL"
+          id: "omnibarTextInput"
       - inputText: "https://privacy-test-pages.site"
       - pressKey: Enter
       - tapOn:
diff --git a/.maestro/bookmarks/open_bookmark_and_navigate_back.yaml b/.maestro/bookmarks/open_bookmark_and_navigate_back.yaml
@@ -13,7 +13,7 @@ tags:
       - runFlow: ../shared/skip_all_onboarding.yaml
 
       - tapOn:
-            text: "search or type URL"
+            id: "omnibarTextInput"
       - inputText: "https://www.search-company.site/"
       - pressKey: Enter
       - assertVisible:
diff --git a/.maestro/bookmarks/open_bookmark_in_folder_and_navigate_back.yaml b/.maestro/bookmarks/open_bookmark_in_folder_and_navigate_back.yaml
@@ -13,7 +13,7 @@ tags:
             - runFlow: ../shared/skip_all_onboarding.yaml
 
             - tapOn:
-                  text: "search or type URL"
+                  id: "omnibarTextInput"
             - inputText: "https://privacy-test-pages.site/"
             - pressKey: Enter
             - assertVisible:
diff --git a/.maestro/browsing/visit_site.yaml b/.maestro/browsing/visit_site.yaml
@@ -12,9 +12,16 @@ tags:
 
       - runFlow: ../shared/skip_all_onboarding.yaml
 
+      - assertVisible:
+          text: "Search"
       - tapOn:
-          text: "search or type URL"
+          id: "omnibarTextInput"
       - inputText: "https://privacy-test-pages.site"
       - pressKey: Enter
       - assertVisible:
           text: ".*Privacy Test Pages.*"
+      - tapOn:
+          id: "omnibarTextInput"
+      - eraseText
+      - assertVisible:
+          text: "Search or type URL"
diff --git a/.maestro/favorites/favorites_bookmarks_add.yaml b/.maestro/favorites/favorites_bookmarks_add.yaml
@@ -13,7 +13,7 @@ tags:
       - runFlow: ../shared/skip_all_onboarding.yaml
 
       - tapOn:
-          text: "search or type URL"
+          id: "omnibarTextInput"
       - inputText: "https://privacy-test-pages.site"
       - pressKey: Enter
       - tapOn:
diff --git a/.maestro/favorites/favorites_bookmarks_delete.yaml b/.maestro/favorites/favorites_bookmarks_delete.yaml
@@ -13,7 +13,7 @@ tags:
       - runFlow: ../shared/skip_all_onboarding.yaml
 
       - tapOn:
-          text: "search or type URL"
+          id: "omnibarTextInput"
       - inputText: "https://privacy-test-pages.site"
       - pressKey: Enter
       - tapOn:
diff --git a/.maestro/fire_button/dimiss_fire_during_onboarding.yaml b/.maestro/fire_button/dimiss_fire_during_onboarding.yaml
@@ -13,7 +13,7 @@ tags:
       - runFlow: ../shared/pre_onboarding.yaml
 
       - tapOn:
-          text: "search or type URL"
+          id: "omnibarTextInput"
       - inputText: "https://privacy-test-pages.site"
       - pressKey: Enter
       - assertVisible:
diff --git a/.maestro/fire_button/fire_during_onboarding.yaml b/.maestro/fire_button/fire_during_onboarding.yaml
@@ -13,7 +13,7 @@ tags:
       - runFlow: ../shared/pre_onboarding.yaml
 
       - tapOn:
-          text: "search or type URL"
+          id: "omnibarTextInput"
       - inputText: "https://privacy-test-pages.site"
       - pressKey: Enter
       - assertVisible:
diff --git a/.maestro/ppro/launch_privacy_pro_from_special_url.yaml b/.maestro/ppro/launch_privacy_pro_from_special_url.yaml
@@ -12,7 +12,7 @@ tags:
       - runFlow: ../shared/skip_all_onboarding.yaml
 
       - tapOn:
-          text: "search or type URL"
+          id: "omnibarTextInput"
       - inputText: "https://duckduckgo.com/pro"
       - pressKey: Enter
       - runFlow:
diff --git a/.maestro/preonboarding/preonboarding_returning_user_start_browsing.yaml b/.maestro/preonboarding/preonboarding_returning_user_start_browsing.yaml
@@ -22,4 +22,4 @@ tags:
     text: "Show Tutorial"
 - tapOn: "Start Browsing"
 - assertVisible:
-    text: "Search or type URL"
+    id: "omnibarTextInput"
diff --git a/.maestro/sync_flows/steps/action_add_bookmarks_and_folders.yaml b/.maestro/sync_flows/steps/action_add_bookmarks_and_folders.yaml
@@ -4,7 +4,8 @@ appId: com.duckduckgo.mobile.android
 - runScript: script_add_bookmark_domains.js
 # Until here we've joined an account that has predefined data
 # Now, we add a couple bookmarks
-- tapOn: "Search or type URL"
+- tapOn:
+    id: "omnibarTextInput"
 - inputText: "${output.bookmarks.domains[0]}"
 # We need this because Dax Dialogs sometimes appears before pressing Enter
 - runFlow:
@@ -25,7 +26,8 @@ appId: com.duckduckgo.mobile.android
 - tapOn:
     id: "com.duckduckgo.mobile.android:id/browserMenuImageView"
 - tapOn: "Add Bookmark"
-- tapOn: "Search or type URL"
+- tapOn:
+    id: "omnibarTextInput"
 # Now, we add a favourite
 - inputText: "${output.bookmarks.domains[1]}"
 - pressKey: Enter
diff --git a/.maestro/tabs/open_multiple_tabs.yaml b/.maestro/tabs/open_multiple_tabs.yaml
@@ -13,7 +13,7 @@ tags:
             - runFlow: ../shared/skip_all_onboarding.yaml
 
             - tapOn:
-                text: "search or type URL"
+                id: "omnibarTextInput"
             - inputText: "https://privacy-test-pages.site"
             - pressKey: Enter
             - tapOn:
@@ -22,7 +22,7 @@ tags:
                 text: "Privacy Test Pages - Home"
             - tapOn: "New Tab"
             - assertVisible:
-                text: "Search or type URL"
+                id: "omnibarTextInput"
             - inputText: "https://www.search-company.site"
             - pressKey: Enter
             - assertVisible:
