Merge branch 'release/5.239.0'

Author: github-actions[bot]

.github/actions/assign-release-task/action.yml

@@ -19,53 +19,79 @@ outputs:
 runs:
   using: 'composite'
   steps:
-    - name: Find task in Asana and assign it to owner
+    - name: Find task, assign it, and write ID to file
       shell: bash
+      env: # Make inputs available as environment variables for easier access in the script
+        INPUT_TASK_NAME: ${{ inputs.task_name }}
+        INPUT_ASANA_TOKEN: ${{ inputs.asana_token }}
+        INPUT_PROJECT_GID: ${{ inputs.project_gid }}
+        INPUT_USERNAME: ${{ inputs.username }}
+        OUTPUT_FILE_PATH: "${{ github.workspace }}/asana_task_id.txt" # Define the output file path
       run: |
-        task_name="${{ inputs.task_name }}"
-        asana_token="${{ inputs.asana_token }}"
-        project_gid="${{ inputs.project_gid }}"
-        username="${{ inputs.username }}"
-
-        # Make the API request to get tasks from the specified project
-        response=$(curl -s -X GET "https://app.asana.com/api/1.0/projects/${project_gid}/tasks" \
-          -H "Authorization: Bearer ${asana_token}")
-
-        # Check if the response contains any tasks that match the specified task name exactly
-        task_id=$(echo "$response" | jq -r '.data[] | select(.name == "'"$task_name"'") | .gid')
+        set -e # Exit immediately if a command exits with a non-zero status.
+        echo "Searching for task: '$INPUT_TASK_NAME' in project GID: '$INPUT_PROJECT_GID'"
+        
+        asana_api_response=$(curl -s -X GET "https://app.asana.com/api/1.0/projects/${INPUT_PROJECT_GID}/tasks" \
+          -H "Authorization: Bearer ${INPUT_ASANA_TOKEN}")
+        
+        # Using jq to extract the task_id - ensure it's robust
+        # This will get the first matching task ID if multiple tasks have the same name.
+        # Add error handling if multiple tasks with the same name is an issue.
+        found_task_id=$(echo "$asana_api_response" | jq -r --arg TASK_NAME "$INPUT_TASK_NAME" '.data[] | select(.name == $TASK_NAME) | .gid | select(.)' | head -n 1)
 
-        if [ -z "$task_id" ]; then
-          echo "No tasks with the exact name '$task_name' found in project GID '$project_gid'."
+        if [ -z "$found_task_id" ]; then
+          echo "::error::No task with the exact name '$INPUT_TASK_NAME' found in project GID '$INPUT_PROJECT_GID'."
+          # Write an empty string or a specific marker to the file if task not found
+          echo "TASK_NOT_FOUND" > "$OUTPUT_FILE_PATH" 
           exit 1
         else
-          echo "Task ID for the task named '$task_name': $task_id"        
-          echo "task_id=$task_id" >> $GITHUB_OUTPUT
+          echo "Found Task ID: '$found_task_id'"
+          # Write the found task ID to the specified file
+          echo "$found_task_id" > "$OUTPUT_FILE_PATH"
+          echo "Task ID successfully written to $OUTPUT_FILE_PATH"
         fi
-      
-        asana_user_id=$(grep -E "^$username: " .github/actions/assign-release-task/github_asana_mapping.yml | awk -F': ' '{print $2}' | tr -d '"')
 
-        if [ -z "asana_user_id" ]; then
-          echo "User $username not found."
-          exit 1
-        else
-          echo "User ID for $username: $asana_user_id"            
-        fi
+        # --- Get Asana User ID ---
+        # Assuming github_asana_mapping.yml is at .github/actions/assign-release-task/github_asana_mapping.yml
+        # relative to the REPO ROOT, not the action directory itself during runtime.
+        # For composite actions, paths in scripts are relative to github.workspace.
+        # If the mapping file is part of the action's folder, the path might need to be:
+        # ${{ github.action_path }}/github_asana_mapping.yml
+        # However, it's often better if such mapping files are at a known repo location.
+        # Let's assume it's checked into the root for simplicity here, or adjust as needed.
+        MAPPING_FILE="${{ github.workspace }}/.github/actions/assign-release-task/github_asana_mapping.yml" # Or adjust path
         
-        echo "Assigning task ID $task_id to user ID $asana_user_id"
-
-        # Assign the task to the user
-        response=$(curl -s -X PUT "https://app.asana.com/api/1.0/tasks/${task_id}" \
-          -H "Authorization: Bearer ${asana_token}" \
-          -H "Content-Type: application/json" \
-          -d "{\"data\": {\"assignee\": \"${asana_user_id}\"}}")            
-
-        # Check if the assignment was successful
-        status=$(echo $response | jq -r '.errors')
-
-        if [ "$status" == "null" ]; then
-          echo "Task $task_id successfully assigned to user $asana_user_id."                
-        else
-          echo "Failed to assign task: $status"
-          exit 1
+        echo "Looking up Asana User ID for GitHub user: '$INPUT_USERNAME' in file: '$MAPPING_FILE'"
+        if [ ! -f "$MAPPING_FILE" ]; then
+            echo "::error::Mapping file not found at $MAPPING_FILE"
+            echo "USER_MAPPING_FILE_NOT_FOUND" > "$OUTPUT_FILE_PATH" # Overwrite with error state
+            exit 1
         fi
-        
+      
+#        asana_user_id=$(grep -E "^$username: " .github/actions/assign-release-task/github_asana_mapping.yml | awk -F': ' '{print $2}' | tr -d '"')
+#
+#        if [ -z "asana_user_id" ]; then
+#          echo "User $username not found."
+#          exit 1
+#        else
+#          echo "User ID for $username: $asana_user_id"
+#        fi
+#
+#        echo "Assigning task ID $task_id to user ID $asana_user_id"
+#
+#        # Assign the task to the user
+#        response=$(curl -s -X PUT "https://app.asana.com/api/1.0/tasks/${task_id}" \
+#          -H "Authorization: Bearer ${asana_token}" \
+#          -H "Content-Type: application/json" \
+#          -d "{\"data\": {\"assignee\": \"${asana_user_id}\"}}")
+#
+#        # Check if the assignment was successful
+#        status=$(echo $response | jq -r '.errors')
+#
+#        if [ "$status" == "null" ]; then
+#          echo "Task $task_id successfully assigned to user $asana_user_id."
+#        else
+#          echo "Failed to assign task: $status"
+#          exit 1
+#        fi
+#

.github/actions/pr-asana-sync/.eslintignore

@@ -0,0 +1,4 @@
+dist/
+lib/
+node_modules/
+jest.config.js

.github/actions/pr-asana-sync/.eslintrc.json

@@ -0,0 +1,32 @@
+{
+  "plugins": ["jest", "@typescript-eslint", "import"],
+  "extends": [
+    "plugin:github/recommended",
+    "plugin:import/typescript",
+    "plugin:@typescript-eslint/recommended"
+  ],
+  "parser": "@typescript-eslint/parser",
+  "parserOptions": {
+    "ecmaVersion": 9,
+    "sourceType": "module",
+    "project": "./tsconfig.json"
+  },
+  "env": {
+    "node": true,
+    "es6": true,
+    "jest/globals": true
+  },
+  "rules": {
+    "i18n-text/no-en": "off"
+  },
+  "settings": {
+    "import/parsers": {
+      "@typescript-eslint/parser": [".ts", ".tsx"]
+    },
+    "import/resolver": {
+      "typescript": {
+        "alwaysTryTypes": true
+      }
+    }
+  }
+}

.github/actions/pr-asana-sync/.gitattributes

@@ -0,0 +1 @@
+dist/** -diff linguist-generated=true

.github/actions/pr-asana-sync/.gitignore

@@ -0,0 +1,98 @@
+# Dependency directory
+node_modules
+
+# Rest pulled from https://github.com/github/gitignore/blob/master/Node.gitignore
+# Logs
+logs
+*.log
+npm-debug.log*
+yarn-debug.log*
+yarn-error.log*
+lerna-debug.log*
+
+# Diagnostic reports (https://nodejs.org/api/report.html)
+report.[0-9]*.[0-9]*.[0-9]*.[0-9]*.json
+
+# Runtime data
+pids
+*.pid
+*.seed
+*.pid.lock
+
+# Directory for instrumented libs generated by jscoverage/JSCover
+lib-cov
+
+# Coverage directory used by tools like istanbul
+coverage
+*.lcov
+
+# nyc test coverage
+.nyc_output
+
+# Grunt intermediate storage (https://gruntjs.com/creating-plugins#storing-task-files)
+.grunt
+
+# Bower dependency directory (https://bower.io/)
+bower_components
+
+# node-waf configuration
+.lock-wscript
+
+# Compiled binary addons (https://nodejs.org/api/addons.html)
+build/Release
+
+# Dependency directories
+jspm_packages/
+
+# TypeScript v1 declaration files
+typings/
+
+# TypeScript cache
+*.tsbuildinfo
+
+# Optional npm cache directory
+.npm
+
+# Optional eslint cache
+.eslintcache
+
+# Optional REPL history
+.node_repl_history
+
+# Output of 'npm pack'
+*.tgz
+
+# Yarn Integrity file
+.yarn-integrity
+
+# dotenv environment variables file
+.env
+.env.test
+
+# parcel-bundler cache (https://parceljs.org/)
+.cache
+
+# next.js build output
+.next
+
+# nuxt.js build output
+.nuxt
+
+# vuepress build output
+.vuepress/dist
+
+# Serverless directories
+.serverless/
+
+# FuseBox cache
+.fusebox/
+
+# DynamoDB Local files
+.dynamodb/
+
+# OS metadata
+.DS_Store
+Thumbs.db
+
+# Ignore built ts files
+__tests__/runner/*

.github/actions/pr-asana-sync/.prettierignore

@@ -0,0 +1,3 @@
+dist/
+lib/
+node_modules/

.github/actions/pr-asana-sync/LICENSE

@@ -0,0 +1,22 @@
+
+The MIT License (MIT)
+
+Copyright (c) 2018 GitHub, Inc. and contributors
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.

.github/actions/pr-asana-sync/README.md

@@ -0,0 +1,52 @@
+# Asana sync action
+
+This is a Github Action for tracking the status of Github Pull requests in Asana. It does the following:
+
+1.  Creates tasks for each new pull request in a project.
+2.  Puts these tasks in a specified Asana project (and optionally section)
+3.  Makes the PR task as a subtask of Asana task referenced in PR description
+4.  Syncs any change to the PR name to Asana.
+5.  Syncs the PR state (Open, Closed, Draft, Merged) to an Asana custom field.
+6.  Creates a subtask for each requested review and automatically resolves these once approved or merged
+
+## Usage
+
+Create a [workflow file](./.github/workflows/asana.yml) that runs on
+`pull_request` and `pull_request_review` events:
+
+```yml
+name: 'asana sync'
+on:
+  pull_request_review:
+  pull_request:
+    types:
+      - opened
+      - edited
+      - closed
+      - reopened
+      - synchronize
+      - review_requested
+
+jobs:
+  sync:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: duckduckgo/action-asana-sync@v1
+        with:
+          ASANA_ACCESS_TOKEN: ${{ secrets.ASANA_ACCESS_TOKEN }}
+          ASANA_WORKSPACE_ID: ${{ secrets.ASANA_WORKSPACE_ID }}
+          ASANA_PROJECT_ID: 'GID of project to create the tasks in'
+```
+
+## Configuration
+
+There are a few additional configuration options that can be used to tweak
+behaviour of this Github Action:
+
+- `NO_AUTOCLOSE_PROJECTS`: By default this action will automatically close PR
+  task it opens. It will not close merged tasks when they are added to projects
+  listed in this variable (comma separated string of IDs). (default: REVIEW/RELEASE project)
+- `SKIPPED_USERS`: Some users don't like receiving reviews in Asana. This is a
+  comma separated list of github usernames that will be ignored (replaced with
+  dax).

.github/actions/pr-asana-sync/action.yml

@@ -0,0 +1,33 @@
+name: "Asana Sync"
+description: "Sync Github PRs to Asana Tasks"
+author: "David Gonzalez based on Quang Nguyen and Sam Macbeth's work"
+inputs:
+  GITHUB_TOKEN:
+    required: true
+    description: "Access token for GitHub API calls"
+  ASANA_ACCESS_TOKEN:
+    required: true
+    description: "Access token for Asana API calls"
+  ASANA_WORKSPACE_ID:
+    required: true
+    description: "ID of your Asana workspace"
+  ASANA_PROJECT_ID:
+    required: true
+    description: "Project ID where issues should be created in Asana"
+  ASANA_IN_PROGRESS_SECTION_ID:
+    required: false
+    description: "If set: move the task to this section once review is in progress"
+  USER_MAP:
+    required: false
+    description: "JSON string mapping Github user IDs to Asana user IDs"
+  RANDOMIZED_REVIEWERS:
+    required: false
+    description: "Comma separated list of GitHub users who can be assigned as randomized reviewers"
+outputs:
+  task_url:
+    description: URL of created/updated PR review task
+  result:
+    description: "Will be one of: created, updated"
+runs:
+  using: "node20"
+  main: "dist/index.js"