Skip to content

Commit 344a3ce

Browse files
authored
Post visual update: Update the favorites item style (#6599)
Task/Issue URL: https://app.asana.com/1/137249556945/project/1207418217763355/task/1210609571927331?focus=true ### Description This PR updates the style of the favorites item on a NTP (new border and corner radius). Design: <img width="350" height="1032" alt="image" src="https://github.com/user-attachments/assets/8de6150d-8015-4a20-8cec-8b687b0f5dcb" /> ### Steps to test this PR _Feature 1_ - [ ] Load a website and add it to the favorite bookmarks - [ ] Open a NTP - [ ] Verify the favorite item matches the new design ### UI changes <img width="350" height="2400" alt="image" src="https://github.com/user-attachments/assets/e62fee40-e6d1-4ef4-a25a-3e6e5370ea7e" />
1 parent 8cd7a41 commit 344a3ce

File tree

3 files changed

+12
-6
lines changed

3 files changed

+12
-6
lines changed

common/common-ui/src/main/res/drawable/background_dashed_outline.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,5 +20,5 @@
2020
android:dashWidth="4dp"
2121
android:dashGap="4dp"
2222
android:color="?attr/daxColorLines" />
23-
<corners android:radius="@dimen/smallShapeCornerRadius" />
23+
<corners android:radius="@dimen/mediumShapeCornerRadius" />
2424
</shape>

saved-sites/saved-sites-impl/src/main/res/layout/view_favourite_section_item.xml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,15 +29,17 @@
2929
android:layout_height="@dimen/gridItemImageSize"
3030
android:layout_gravity="center_horizontal"
3131
app:cardBackgroundColor="?attr/daxColorSurface"
32-
app:cardCornerRadius="@dimen/smallShapeCornerRadius"
32+
app:cardCornerRadius="@dimen/mediumShapeCornerRadius"
3333
tools:visibility="gone"
34-
app:cardElevation="2dp">
34+
app:cardElevation="0dp">
3535

36-
<ImageView
36+
<com.google.android.material.imageview.ShapeableImageView
3737
android:id="@+id/quickAccessFavicon"
38-
android:layout_width="@dimen/gridItemImageSize"
39-
android:layout_height="@dimen/gridItemImageSize"
38+
android:layout_width="match_parent"
39+
android:layout_height="match_parent"
40+
android:padding="@dimen/keyline_2"
4041
android:layout_gravity="center"
42+
app:shapeAppearanceOverlay="@style/Widget.DuckDuckGo.FavouritesItemFavicon"
4143
android:importantForAccessibility="no" />
4244

4345
</com.google.android.material.card.MaterialCardView>

saved-sites/saved-sites-impl/src/main/res/values/styles-saved-sites.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,4 +21,8 @@
2121
<item name="android:layout_height">match_parent</item>
2222
<item name="isExpandable">true</item>
2323
</style>
24+
<style name="Widget.DuckDuckGo.FavouritesItemFavicon">
25+
<item name="cornerFamily">rounded</item>
26+
<item name="cornerSize">@dimen/smallShapeCornerRadius</item>
27+
</style>
2428
</resources>

0 commit comments

Comments
 (0)