Skip to content

Commit 3f7e4e4

Browse files
authored
Fix flaky bookmark tests (#7809)
Task/Issue URL: https://app.asana.com/1/137249556945/project/1202552961248957/task/1213430504228545?focus=true ### Description Fix flaky Maestro tests for bookmarks by removing step to hide keyboard ### Steps to test this PR _Feature 1_ - [x] Check [release tests](https://app.maestro.dev/project/proj_01htg54rdtfwx8rgbzv03cxkpf/maestro-test/app/app_01hkqhj1thevwtn9ym8a2ctn2r/upload/mupload_01kja2htwrfr8s79saxhmeta0g?sort=name) pass in Maestro. In particular: - [x] [ReleaseTest: Bookmarks can be added and deleted](https://app.maestro.dev/project/proj_01htg54rdtfwx8rgbzv03cxkpf/maestro-test/flow/run_01kja2hvageaqtmsb82h954nat) - [x] [ReleaseTest: Bookmark open and back navigation](https://app.maestro.dev/project/proj_01htg54rdtfwx8rgbzv03cxkpf/maestro-test/flow/run_01kja2hv6sesh88cr4mxykf19f) - [x] [ReleaseTest: Bookmark open in folder and back navigation](https://app.maestro.dev/project/proj_01htg54rdtfwx8rgbzv03cxkpf/maestro-test/flow/run_01kja2hv8mfgh8bvjtcgjmwfsm) ### UI changes n/a <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Test-only changes that adjust UI automation steps; no production code paths or data handling are affected. > > **Overview** > Stabilizes the Maestro bookmark release tests by replacing the shared `click_on_menu_button` subflow with direct `tapOn` interactions on `browserMenuImageView` when opening the browser menu. > > This updates three bookmark flows (add/delete, open+back, and folder navigation) to remove conditional logic/keyboard handling from the menu-opening step, reducing flakiness during menu access. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 07fad30. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent 53676b2 commit 3f7e4e4

File tree

3 files changed

+12
-6
lines changed

3 files changed

+12
-6
lines changed

.maestro/bookmarks/ensure_bookmarks_can_be_added_and_deleted.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,14 @@ tags:
1616
id: "omnibarTextInput"
1717
- inputText: "https://privacy-test-pages.site"
1818
- pressKey: Enter
19-
- runFlow: ../shared/browser_screen/click_on_menu_button.yaml
19+
- tapOn:
20+
id: 'com.duckduckgo.mobile.android:id/browserMenuImageView'
2021
- assertVisible:
2122
text: "add bookmark"
2223
- tapOn:
2324
text: "add bookmark"
24-
- runFlow: ../shared/browser_screen/click_on_menu_button.yaml
25+
- tapOn:
26+
id: 'com.duckduckgo.mobile.android:id/browserMenuImageView'
2527
- assertVisible:
2628
text: "bookmarks"
2729
- tapOn:

.maestro/bookmarks/open_bookmark_and_navigate_back.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,14 @@ tags:
2424
- pressKey: Enter
2525
- assertVisible:
2626
text: "Privacy Test Pages"
27-
- runFlow: ../shared/browser_screen/click_on_menu_button.yaml
27+
- tapOn:
28+
id: 'com.duckduckgo.mobile.android:id/browserMenuImageView'
2829
- assertVisible:
2930
text: "add bookmark"
3031
- tapOn:
3132
text: "add bookmark"
32-
- runFlow: ../shared/browser_screen/click_on_menu_button.yaml
33+
- tapOn:
34+
id: 'com.duckduckgo.mobile.android:id/browserMenuImageView'
3335
- assertVisible:
3436
text: "bookmarks"
3537
- tapOn:

.maestro/bookmarks/open_bookmark_in_folder_and_navigate_back.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@ tags:
1818
- pressKey: Enter
1919
- assertVisible:
2020
text: "Privacy Test Pages"
21-
- runFlow: ../shared/browser_screen/click_on_menu_button.yaml
21+
- tapOn:
22+
id: 'com.duckduckgo.mobile.android:id/browserMenuImageView'
2223
- assertVisible:
2324
text: "add bookmark"
2425
- tapOn:
@@ -29,7 +30,8 @@ tags:
2930
- pressKey: Enter
3031
- assertVisible:
3132
text: "Search engine"
32-
- runFlow: ../shared/browser_screen/click_on_menu_button.yaml
33+
- tapOn:
34+
id: 'com.duckduckgo.mobile.android:id/browserMenuImageView'
3335
- assertVisible:
3436
text: "bookmarks"
3537
- tapOn:

0 commit comments

Comments
 (0)