Improve thread safety

Author: CrisBarreiro

app/src/androidTest/java/com/duckduckgo/app/browser/BrowserWebViewClientTest.kt

@@ -1353,7 +1353,7 @@ class BrowserWebViewClientTest {
         }
 
         // TODO (cbarreiro) Test message posting
-        override fun postMessage(subscriptionEventData: SubscriptionEventData): Boolean {
+        override suspend fun postMessage(subscriptionEventData: SubscriptionEventData): Boolean {
             TODO("Not yet implemented")
         }
     }

app/src/main/java/com/duckduckgo/app/browser/BrowserWebViewClient.kt

@@ -783,7 +783,7 @@ class BrowserWebViewClient @Inject constructor(
         }
     }
 
-    fun postMessage(
+    suspend fun postMessage(
         eventData: SubscriptionEventData,
         fallback: () -> Unit,
     ) {

content-scope-scripts/content-scope-scripts-impl/src/main/java/com/duckduckgo/contentscopescripts/impl/messaging/WebViewCompatWebCompatMessagingPlugin.kt

@@ -39,7 +39,6 @@ import com.squareup.moshi.Moshi
 import javax.inject.Inject
 import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.launch
-import kotlinx.coroutines.runBlocking
 import kotlinx.coroutines.withContext
 import logcat.LogPriority.ERROR
 import logcat.asLog
@@ -208,14 +207,9 @@ class WebViewCompatWebCompatMessagingPlugin @Inject constructor(
     }
 
     @SuppressLint("RequiresFeature")
-    override fun postMessage(subscriptionEventData: SubscriptionEventData): Boolean {
+    override suspend fun postMessage(subscriptionEventData: SubscriptionEventData): Boolean {
         return runCatching {
-            // TODO (cbarreiro) temporary, remove
-            val newWebCompatApisEnabled = runBlocking {
-                webViewCompatContentScopeScripts.isEnabled()
-            }
-
-            if (!newWebCompatApisEnabled) {
+            if (!webViewCompatContentScopeScripts.isEnabled()) {
                 return false
             }
 
@@ -228,8 +222,10 @@ class WebViewCompatWebCompatMessagingPlugin @Inject constructor(
                 moshi.adapter(SubscriptionEvent::class.java).toJson(it)
             }
 
-            globalReplyProxy?.postMessage(subscriptionEvent)
-            true
+            withContext(dispatcherProvider.main()) {
+                globalReplyProxy?.postMessage(subscriptionEvent)
+                true
+            }
         }.getOrElse { false }
     }
 }

js-messaging/js-messaging-api/src/main/java/com/duckduckgo/js/messaging/api/WebMessagingPlugin.kt

@@ -28,5 +28,5 @@ interface WebMessagingPlugin {
         unregisterer: suspend (objectName: String) -> Boolean,
     )
 
-    fun postMessage(subscriptionEventData: SubscriptionEventData): Boolean
+    suspend fun postMessage(subscriptionEventData: SubscriptionEventData): Boolean
 }