Feature/remove closed experiments (#345)

* Remove onboarding as an experimental feature

* Remove variants which have ended

Author: CDRussell

app/src/androidTest/java/com/duckduckgo/app/browser/BrowserTabViewModelTest.kt

@@ -32,8 +32,6 @@ import com.duckduckgo.app.browser.BrowserTabViewModel.Command.DisplayMessage
 import com.duckduckgo.app.browser.BrowserTabViewModel.Command.Navigate
 import com.duckduckgo.app.browser.LongPressHandler.RequiredAction.DownloadFile
 import com.duckduckgo.app.browser.LongPressHandler.RequiredAction.OpenInNewTab
-import com.duckduckgo.app.browser.defaultBrowsing.DefaultBrowserDetector
-import com.duckduckgo.app.browser.defaultBrowsing.DefaultBrowserNotification
 import com.duckduckgo.app.browser.favicon.FaviconDownloader
 import com.duckduckgo.app.browser.omnibar.OmnibarEntryConverter
 import com.duckduckgo.app.browser.session.WebViewSessionStorage
@@ -47,7 +45,6 @@ import com.duckduckgo.app.privacy.db.SiteVisitedEntity
 import com.duckduckgo.app.privacy.model.PrivacyGrade
 import com.duckduckgo.app.privacy.store.TermsOfServiceStore
 import com.duckduckgo.app.settings.db.SettingsDataStore
-import com.duckduckgo.app.statistics.VariantManager
 import com.duckduckgo.app.statistics.api.StatisticsUpdater
 import com.duckduckgo.app.tabs.model.TabRepository
 import com.duckduckgo.app.trackerdetection.model.TrackerNetwork
@@ -104,21 +101,12 @@ class BrowserTabViewModelTest {
     @Mock
     private lateinit var mockOmnibarConverter: OmnibarEntryConverter
 
-    @Mock
-    private lateinit var mockDefaultBrowserDetector: DefaultBrowserDetector
-
-    @Mock
-    private lateinit var mockDefaultBrowserNotification: DefaultBrowserNotification
-
     @Mock
     private lateinit var mockTabsRepository: TabRepository
 
     @Mock
     private lateinit var webViewSessionStorage: WebViewSessionStorage
 
-    @Mock
-    private lateinit var variantManager: VariantManager
-
     @Mock
     private lateinit var mockFaviconDownloader: FaviconDownloader
 
@@ -154,14 +142,11 @@ class BrowserTabViewModelTest {
             autoCompleteApi = mockAutoCompleteApi,
             appSettingsPreferencesStore = mockSettingsStore,
             bookmarksDao = bookmarksDao,
-            defaultBrowserNotification = mockDefaultBrowserNotification,
-            defaultBrowserDetector = mockDefaultBrowserDetector,
             longPressHandler = mockLongPressHandler,
             appConfigurationDao = appConfigurationDao,
             webViewSessionStorage = webViewSessionStorage,
             specialUrlDetector = SpecialUrlDetector(),
-            faviconDownloader = mockFaviconDownloader,
-            variantManager = variantManager
+            faviconDownloader = mockFaviconDownloader
         )
 
         testee.loadData("abc", null)

app/src/androidTest/java/com/duckduckgo/app/browser/defaultBrowsing/DefaultBrowserBannerNotificationTest.kt

@@ -20,7 +20,6 @@ import android.app.Application
 import com.duckduckgo.app.TestApplication
 import com.duckduckgo.app.browser.autoComplete.BrowserAutoCompleteModule
 import com.duckduckgo.app.browser.di.BrowserModule
-import com.duckduckgo.app.browser.di.DefaultBrowserModule
 import com.duckduckgo.app.browser.favicon.FaviconModule
 import com.duckduckgo.app.httpsupgrade.di.HttpsUpgraderModule
 import com.duckduckgo.app.onboarding.di.OnboardingModule
@@ -55,7 +54,6 @@ import javax.inject.Singleton
     ResourceSurrogateModule::class,
     TrackerDetectionModule::class,
     NotificationModule::class,
-    DefaultBrowserModule::class,
     OnboardingModule::class,
     VariantModule::class,
     FaviconModule::class

app/src/androidTest/java/com/duckduckgo/app/browser/defaultBrowsing/DefaultBrowserHomeScreenCallToActionTest.kt

@@ -35,16 +35,6 @@ class AppInstallSharedPreferencesTest {
         testee = AppInstallSharedPreferences(context)
     }
 
-    @Test
-    fun whenInitializedThenUserHasNotBeenMarkedAsHavingPreviouslyDeclinedBanner() {
-        assertFalse(testee.hasUserDeclinedDefaultBrowserBannerPreviously())
-    }
-
-    @Test
-    fun whenInitializedThenUserHasNotBeenMarkedAsHavingPreviouslyDeclinedHomeScreenCallToAction() {
-        assertFalse(testee.hasUserDeclinedDefaultBrowserHomeScreenCallToActionPreviously())
-    }
-
     @Test
     fun whenInitializedThenInstallTimestampNotYetRecorded() {
         assertFalse(testee.hasInstallTimestampRecorded())
@@ -63,19 +53,4 @@ class AppInstallSharedPreferencesTest {
         testee.installTimestamp = timestamp
         assertEquals(timestamp, testee.installTimestamp)
     }
-
-    @Test
-    fun whenUserPreviouslyDeclinedBannerThenThatIsReturnedWhenQueried() {
-        val timestamp = 1L
-        testee.recordUserDeclinedBannerToSetDefaultBrowser(timestamp)
-        assertTrue(testee.hasUserDeclinedDefaultBrowserBannerPreviously())
-    }
-
-    @Test
-    fun whenUserPreviouslyDeclinedHomeScreenCallToActionThenThatIsReturnedWhenQueried() {
-        val timestamp = 1L
-        testee.recordUserDeclinedHomeScreenCallToActionToSetDefaultBrowser(timestamp)
-        assertTrue(testee.hasUserDeclinedDefaultBrowserHomeScreenCallToActionPreviously())
-    }
-
 }

app/src/androidTest/java/com/duckduckgo/app/di/TestAppComponent.kt

@@ -16,38 +16,14 @@
 
 package com.duckduckgo.app.statistics
 
-import com.duckduckgo.app.statistics.VariantManager.VariantFeature.DefaultBrowserFeature.ShowHomeScreenCallToActionBottomSheet
-import com.duckduckgo.app.statistics.VariantManager.VariantFeature.DefaultBrowserFeature.ShowHomeScreenCallToActionSimpleButton
-import org.junit.Assert.*
+import org.junit.Assert.assertEquals
+import org.junit.Assert.fail
 import org.junit.Test
 
 class VariantManagerTest {
 
     private val variants = VariantManager.ACTIVE_VARIANTS
 
-    @Test
-    fun homeScreenCallToActionButtonVariantConfiguredCorrectly() {
-        val variant = variants.firstOrNull { it.key == "mq" }
-        assertEqualsDouble(1.0, variant!!.weight)
-        assertTrue(variant.hasFeature(ShowHomeScreenCallToActionSimpleButton))
-        assertEquals(1, variant.features.size)
-    }
-
-    @Test
-    fun homeScreenCallToActionBottomSheetVariantConfiguredCorrectly() {
-        val variant = variants.firstOrNull { it.key == "mp" }
-        assertEqualsDouble(1.0, variant!!.weight)
-        assertTrue(variant.hasFeature(ShowHomeScreenCallToActionBottomSheet))
-        assertEquals(1, variant.features.size)
-    }
-
-    @Test
-    fun controlVariantConfiguredCorrectly() {
-        val variant = variants.firstOrNull { it.key == "mr" }
-        assertEqualsDouble(1.0, variant!!.weight)
-        assertEquals(0, variant.features.size)
-    }
-
     @Test
     fun serpVariantAConfiguredCorrectly() {
         val variant = variants.firstOrNull { it.key == "sa" }