Test subscriptions

Author: CrisBarreiro

content-scope-scripts/content-scope-scripts-impl/src/main/java/com/duckduckgo/contentscopescripts/impl/messaging/AdsjsContentScopeMessaging.kt

@@ -26,7 +26,6 @@ import com.duckduckgo.common.utils.plugins.PluginPoint
 import com.duckduckgo.contentscopescripts.api.AdsjsContentScopeJsMessageHandlersPlugin
 import com.duckduckgo.contentscopescripts.api.GlobalContentScopeJsMessageHandlersPlugin
 import com.duckduckgo.contentscopescripts.impl.AdsJsContentScopeScripts
-import com.duckduckgo.contentscopescripts.impl.ContentScopeScriptsFeature
 import com.duckduckgo.di.scopes.ActivityScope
 import com.duckduckgo.js.messaging.api.AdsjsJsMessageCallback
 import com.duckduckgo.js.messaging.api.AdsjsMessaging
@@ -56,12 +55,11 @@ class AdsjsContentScopeMessaging @Inject constructor(
     private val adsJsContentScopeScripts: AdsJsContentScopeScripts,
     private val dispatcherProvider: DispatcherProvider,
     @AppCoroutineScope private val appCoroutineScope: CoroutineScope,
-    private val contentScopeScriptsFeature: ContentScopeScriptsFeature,
 ) : AdsjsMessaging {
 
     private val moshi = Moshi.Builder().add(JSONObjectAdapter()).build()
 
-    private lateinit var webView: WebView
+    private var webView: WebView? = null
 
     override val context: String = "contentScopeScripts"
     override val allowedDomains: Set<String> = setOf("*")
@@ -176,7 +174,7 @@ class AdsjsContentScopeMessaging @Inject constructor(
 
     override suspend fun postMessage(subscriptionEventData: SubscriptionEventData): Boolean {
         val newWebCompatApisEnabled = withContext(dispatcherProvider.io()) {
-            contentScopeScriptsFeature.useNewWebCompatApis().isEnabled()
+            adsJsContentScopeScripts.isEnabled()
         }
 
         if (!newWebCompatApisEnabled) {
@@ -197,9 +195,11 @@ class AdsjsContentScopeMessaging @Inject constructor(
                 (webView as? DuckDuckGoWebView)?.safePostMessage(
                     it,
                     subscriptionEvent,
-                )
+                )?.also {
+                    return@withContext true
+                }
             }
-            return@withContext true
+            return@withContext false
         }
     }
 }

content-scope-scripts/content-scope-scripts-impl/src/test/java/com/duckduckgo/contentscopescripts/impl/messaging/AdsjsContentScopeScriptsJsMessagingTest.kt

@@ -28,9 +28,12 @@ import com.duckduckgo.contentscopescripts.impl.AdsJsContentScopeScripts
 import com.duckduckgo.js.messaging.api.AdsjsJsMessageCallback
 import com.duckduckgo.js.messaging.api.AdsjsMessageHandler
 import com.duckduckgo.js.messaging.api.JsMessage
+import com.duckduckgo.js.messaging.api.SubscriptionEventData
 import junit.framework.TestCase.assertEquals
 import kotlinx.coroutines.test.runTest
 import org.json.JSONObject
+import org.junit.Assert.assertFalse
+import org.junit.Assert.assertTrue
 import org.junit.Before
 import org.junit.Rule
 import org.junit.Test
@@ -221,6 +224,67 @@ class AdsjsContentScopeScriptsJsMessagingTest {
         verify(mockWebView).safeRemoveWebMessageListener(any())
     }
 
+    @Test
+    fun `when posting message and adsjs is disabled then do not post message`() = runTest {
+        whenever(adsJsContentScopeScripts.isEnabled()).thenReturn(false)
+        val eventData = SubscriptionEventData("feature", "subscription", JSONObject())
+        register()
+        processInitialPing()
+
+        val result = contentScopeScriptsJsMessaging.postMessage(eventData)
+
+        verify(mockWebView, never()).safePostMessage(any(), any())
+        assertFalse(result)
+    }
+
+    @Test
+    fun `when posting message and adsjs is enabled but webView not registered then do not post message`() = runTest {
+        whenever(adsJsContentScopeScripts.isEnabled()).thenReturn(true)
+        val eventData = SubscriptionEventData("feature", "subscription", JSONObject())
+        processInitialPing()
+
+        val result = contentScopeScriptsJsMessaging.postMessage(eventData)
+
+        verify(mockWebView, never()).safePostMessage(any(), any())
+        assertFalse(result)
+    }
+
+    @Test
+    fun `when posting message and adsjs is enabled but initialPing not processes then do not post message`() = runTest {
+        whenever(adsJsContentScopeScripts.isEnabled()).thenReturn(true)
+        val eventData = SubscriptionEventData("feature", "subscription", JSONObject())
+
+        val result = contentScopeScriptsJsMessaging.postMessage(eventData)
+
+        verify(mockWebView, never()).safePostMessage(any(), any())
+        assertFalse(result)
+    }
+
+    @Test
+    fun `when posting message after getting initialPing and adsjs is enabled then post message`() = runTest {
+        whenever(adsJsContentScopeScripts.isEnabled()).thenReturn(true)
+        val eventData = SubscriptionEventData("feature", "subscription", JSONObject())
+        register()
+        processInitialPing()
+        verify(mockWebView, never()).postWebMessage(any(), any())
+
+        val result = contentScopeScriptsJsMessaging.postMessage(eventData)
+
+        verify(mockWebView).safePostMessage(any(), any())
+        assertTrue(result)
+    }
+
+    private fun register() = runTest {
+        contentScopeScriptsJsMessaging.register(mockWebView, callback)
+    }
+
+    private fun processInitialPing() = runTest {
+        val message = """
+            {"context":"contentScopeScripts","featureName":"messaging","id":"debugId","method":"initialPing","params":{}}
+        """.trimIndent()
+        contentScopeScriptsJsMessaging.process(message, callback, mockReplyProxy)
+    }
+
     private val callback = object : AdsjsJsMessageCallback {
         var counter = 0
         override fun process(