Skip to content

Commit 4a7c936

Browse files
authored
Update privacy grade observer init timing
Move privacy grade observer to onCreateMenuOptions so that privacy grade isn't updated before menu is available
1 parent 753864e commit 4a7c936

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

app/src/main/java/com/duckduckgo/app/browser/BrowserActivity.kt

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -88,12 +88,6 @@ class BrowserActivity : DuckDuckGoActivity() {
8888
it?.let { render(it) }
8989
})
9090

91-
viewModel.privacyGrade.observe(this, Observer<PrivacyGrade> {
92-
it?.let {
93-
privacyGradeMenu?.icon = getDrawable(it.icon())
94-
}
95-
})
96-
9791
viewModel.url.observe(this, Observer {
9892
it?.let { webView.loadUrl(it) }
9993
})
@@ -318,6 +312,11 @@ class BrowserActivity : DuckDuckGoActivity() {
318312

319313
override fun onCreateOptionsMenu(menu: Menu?): Boolean {
320314
menuInflater.inflate(R.menu.menu_browser_activity, menu)
315+
viewModel.privacyGrade.observe(this, Observer<PrivacyGrade> {
316+
it?.let {
317+
privacyGradeMenu?.icon = getDrawable(it.icon())
318+
}
319+
})
321320
return true
322321
}
323322

0 commit comments

Comments
 (0)