Skip to content

Commit 4b0de61

Browse files
committed
Merge branch 'release/5.84.2' into main
2 parents 61cebdf + 74cf57f commit 4b0de61

File tree

5 files changed

+24
-16
lines changed

5 files changed

+24
-16
lines changed

app/version/version.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
VERSION=5.84.1
1+
VERSION=5.84.2

fastlane/Fastfile

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ platform :android do
2020
desc "Upload APK to Play Store"
2121
lane :deploy_playstore do
2222

23+
update_fastlane_release_notes()
24+
2325
props = property_file_read(file: "app/version/version.properties")
2426
version = props["VERSION"]
2527
apkPath = "app/build/outputs/apk/play/release/duckduckgo-#{version}-play-release.apk"
@@ -28,8 +30,12 @@ platform :android do
2830
apk: apkPath,
2931
track: 'internal',
3032
skip_upload_screenshots: true,
31-
skip_upload_images: true
33+
skip_upload_images: true,
34+
validate_only: false
3235
)
36+
37+
cleanup_fastlane_release_notes()
38+
3339
end
3440

3541
desc "Upload APK to ad-hoc internal app sharing"
@@ -79,6 +85,17 @@ platform :android do
7985

8086
end
8187

88+
desc "Clean up local changelist metadata"
89+
lane :cleanup_fastlane_release_notes do
90+
91+
flversion=gradle(task: '-q fastlaneVersionCode')
92+
UI.message("Fastlane version is #{flversion}.")
93+
94+
sh("rm '../fastlane/metadata/android/en-US/changelogs/#{flversion}.txt'")
95+
sh("rm '../fastlane/metadata/android/en-GB/changelogs/#{flversion}.txt'")
96+
97+
end
98+
8299
# Note, this currently relies on having `git flow` tools installed.
83100
# This dependency could be removed with a little more time to tidy up this script to do the branching/merging manually.
84101

@@ -122,8 +139,6 @@ platform :android do
122139
You can always reach us at https://duckduckgo.com/feedback.""")
123140
end
124141

125-
update_fastlane_release_notes()
126-
127142
if UI.confirm(text:"If you have any other changes to make to the release branch, do them now. Enter `y` when ready to create and push tags")
128143

129144
git_commit(path: "*", message: "Updated release notes and version number for new release - #{newVersion}")

fastlane/README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,11 @@ Deploy APK to GitHub
3636
fastlane android update_fastlane_release_notes
3737
```
3838
Update local changelist metadata
39+
### android cleanup_fastlane_release_notes
40+
```
41+
fastlane android cleanup_fastlane_release_notes
42+
```
43+
Clean up local changelist metadata
3944
### android release
4045
```
4146
fastlane android release

fastlane/metadata/android/en-GB/changelogs/58100.txt

Lines changed: 0 additions & 6 deletions
This file was deleted.

fastlane/metadata/android/en-US/changelogs/58100.txt

Lines changed: 0 additions & 6 deletions
This file was deleted.

0 commit comments

Comments
 (0)