Skip to content

Commit 4f80008

Browse files
authored
Quick win: Add disabled state tint to navigation buttons (#6775)
Task/Issue URL: https://app.asana.com/1/137249556945/project/1207418217763355/task/1211090044160804?focus=true ### Description This PR adds the disabled state colors to the navigation buttons (forward, backwards, refresh) when they're disabled. ### Steps to test this PR _NTP_ - [ ] Open a NTP - [ ] Open the browser menu - [ ] Verify all navigation buttons use the disabled color - [ ] Navigate to some website - [ ] Open the browser menu - [ ] Verify only the forward button is disabled _Bottom omnibar_ - [ ] Change the omnibar position to the bottom - [ ] Repeat steps from _NTP_ _Dark mode_ - [ ] Change the theme to dark mode - [ ] Repeat steps from _NTP ### UI changes | Light | Dark | | ------ | ----- | <img width="1080" height="2400" alt="image" src="https://github.com/user-attachments/assets/a623e398-a68d-4ff9-a34e-6ce4a437c1e5" />|<img width="1080" height="2400" alt="image" src="https://github.com/user-attachments/assets/756db9ce-57df-4bf5-80da-e9f23bb51a7e" />|
1 parent af9f82a commit 4f80008

File tree

5 files changed

+9
-7
lines changed

5 files changed

+9
-7
lines changed

app/src/main/res/layout/popup_window_browser_menu.xml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
<?xml version="1.0" encoding="utf-8"?><!--
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<!--
23
~ Copyright (c) 2020 DuckDuckGo
34
~
45
~ Licensed under the Apache License, Version 2.0 (the "License");
@@ -254,4 +255,4 @@
254255

255256
</ScrollView>
256257

257-
</LinearLayout>
258+
</LinearLayout>

app/src/main/res/layout/popup_window_browser_menu_bottom.xml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
<?xml version="1.0" encoding="utf-8"?><!--
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<!--
23
~ Copyright (c) 2020 DuckDuckGo
34
~
45
~ Licensed under the Apache License, Version 2.0 (the "License");
@@ -255,4 +256,4 @@
255256

256257
</androidx.constraintlayout.widget.ConstraintLayout>
257258

258-
</LinearLayout>
259+
</LinearLayout>

common/common-ui/src/main/res/drawable/ic_arrow_left_24.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@
55
android:viewportHeight="24">
66
<path
77
android:pathData="M10.805,4.031a0.75,0.75 0,0 0,-1.06 -1.06l-7.014,7.01a2.5,2.5 0,0 0,0 3.536l7.013,7.012a0.75,0.75 0,1 0,1.06 -1.06L3.837,12.5h17.415a0.75,0.75 0,0 0,0 -1.5H3.836l6.969,-6.969Z"
8-
android:fillColor="?attr/daxColorPrimaryIcon"/>
8+
android:fillColor="@color/primary_icon_color_selector"/>
99
</vector>

common/common-ui/src/main/res/drawable/ic_arrow_right_24.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@
55
android:viewportHeight="24">
66
<path
77
android:pathData="M13.196,4.031a0.75,0.75 0,0 1,1.06 -1.06l7.012,7.011a2.5,2.5 0,0 1,0 3.536l-7.012,7.012a0.75,0.75 0,0 1,-1.06 -1.06l6.969,-6.97H2.75a0.75,0.75 0,0 1,0 -1.5h17.415l-6.97,-6.969Z"
8-
android:fillColor="?attr/daxColorPrimaryIcon"/>
8+
android:fillColor="@color/primary_icon_color_selector"/>
99
</vector>

common/common-ui/src/main/res/drawable/ic_reload_24.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@
55
android:viewportHeight="24">
66
<path
77
android:pathData="M20.055,14.907a0.815,0.815 0,0 1,0.756 -0.55c0.496,0 0.862,0.466 0.7,0.935 -1.363,3.917 -5.087,6.728 -9.468,6.728 -5.534,0 -10.02,-4.486 -10.02,-10.02S6.509,1.98 12.043,1.98A10.01,10.01 0,0 1,20.5 6.623V4.25a0.75,0.75 0,0 1,1.5 0V7a2.5,2.5 0,0 1,-2.5 2.5h-2.75a0.75,0.75 0,0 1,0 -1.5h2.75c0.023,0 0.045,0 0.067,-0.002a8.52,8.52 0,1 0,0.488 6.91Z"
8-
android:fillColor="?attr/daxColorPrimaryIcon"/>
8+
android:fillColor="@color/primary_icon_color_selector"/>
99
</vector>

0 commit comments

Comments
 (0)