Merge branch 'release/5.253.0'

Author: github-actions[bot]

.githooks/pre-commit

@@ -1,6 +1,13 @@
-
     #!/bin/bash
     echo "Running spotless check"
     ./gradlew spotlessApply
+
+    echo "Running PixelDefinitions lint fix (npm run lint.fix)"
+    pushd PixelDefinitions >/dev/null
+    npm install
+    # Auto fix pixel-schema lint issues
+    npm run lint.fix
+    popd >/dev/null
+
     git add `git diff --name-only --cached`
-    exit 0
+    exit 0

.github/workflows/pixel-validation.yml

@@ -0,0 +1,50 @@
+name: Pixel Schema Validation
+
+on:
+    push:
+      branches:
+      - develop
+    pull_request:
+      paths:
+      - 'PixelDefinitions/**'
+
+jobs:
+    pixel-validation:
+        runs-on: ubuntu-latest
+        permissions:
+            contents: write
+        steps:
+            - name: Checkout repository
+              uses: actions/checkout@v4
+
+            - name: Use Node.js 20
+              uses: actions/setup-node@v4
+              with:
+                node-version: 20.x
+
+            - uses: actions/cache@v4
+              with:
+                path: ~/.npm
+                key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
+                restore-keys: |
+                  ${{ runner.os }}-node-
+
+            - name: Checkout internal-github-asana-utils repo
+              uses: actions/checkout@v4
+              with:
+                  token: ${{ secrets.DAXMOBILE_ANDROID_AUTOMATION }}
+                  path: internal-github-asana-utils
+                  repository: duckduckgo/internal-github-asana-utils
+
+            - name: Install dependencies
+              run: npm ci --verbose
+              working-directory: PixelDefinitions
+
+            - name: Lint
+              run: npm run lint || (npm run lint.fix; git --no-pager diff; echo 'Pixel lint check failed, review diff above or run "npm run lint.fix"'; exit 1)
+              working-directory: PixelDefinitions
+
+            - name: Run pixel validation
+              run: npm run validate-defs-without-formatting -- -g ../internal-github-asana-utils/user_map.yml
+              working-directory: PixelDefinitions
+

.gitignore

@@ -101,4 +101,8 @@ report
 !/node_modules/@duckduckgo/content-scope-scripts/build/android/
 !/node_modules/@duckduckgo/content-scope-scripts/build/android/pages/
 /node_modules/@duckduckgo/content-scope-scripts/build/android/pages/*
-!/node_modules/@duckduckgo/content-scope-scripts/build/android/pages/duckplayer/
+!/node_modules/@duckduckgo/content-scope-scripts/build/android/pages/duckplayer/
+
+# Pixel processing results
+PixelDefinitions/pixel_processing_results/*
+PixelDefinitions/node_modules/

PixelDefinitions/.prettierignore

@@ -0,0 +1 @@
+*.md

PixelDefinitions/README.md

@@ -0,0 +1 @@
+For information about documenting pixels and validating them, see https://github.com/duckduckgo/pixel-schema/blob/main/README.md

PixelDefinitions/asana_notify.json

@@ -0,0 +1,5 @@
+{
+    "assignee": "ladamski",
+    "followers": ["nshuba"],
+    "tagPixelOwners": false
+}

PixelDefinitions/ignore_params.json

@@ -0,0 +1 @@
+{}

PixelDefinitions/native_experiments.json5

@@ -0,0 +1,5 @@
+{
+    // This file will define pixels sent by the native experiments framework
+    "defaultSuffixes": ["form_factor"],
+    "activeExperiments": {}
+}