Skip to content

Commit 5378c6b

Browse files
authored
Remove experiment cohorts in feedback form code (#6989)
Task/Issue URL: https://app.asana.com/1/137249556945/project/1207908166761516/task/1210979364522298?focus=true ### Description No longer needed as the experiment is off and just tidying up. Removes unneeded code from this #6544 ### Steps to test this PR - [ ] Send feedback via the feedback form. - [ ] Check the pixel contains the atb parameter - [ ] The pixel should only contain the atb without any cohorts ### UI changes N/A
1 parent 1183b6b commit 5378c6b

File tree

2 files changed

+1
-13
lines changed

2 files changed

+1
-13
lines changed

app/src/main/java/com/duckduckgo/app/di/NetworkModule.kt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ import com.duckduckgo.app.feedback.api.FeedbackSubmitter
2222
import com.duckduckgo.app.feedback.api.FireAndForgetFeedbackSubmitter
2323
import com.duckduckgo.app.feedback.api.SubReasonApiMapper
2424
import com.duckduckgo.app.global.api.*
25-
import com.duckduckgo.app.onboardingdesignexperiment.OnboardingDesignExperimentManager
2625
import com.duckduckgo.app.statistics.pixels.Pixel
2726
import com.duckduckgo.app.statistics.store.StatisticsDataStore
2827
import com.duckduckgo.appbuildconfig.api.AppBuildConfig
@@ -173,7 +172,6 @@ class NetworkModule {
173172
@AppCoroutineScope appCoroutineScope: CoroutineScope,
174173
appBuildConfig: AppBuildConfig,
175174
dispatcherProvider: DispatcherProvider,
176-
onboardingDesignExperimentManager: OnboardingDesignExperimentManager,
177175
): FeedbackSubmitter =
178176
FireAndForgetFeedbackSubmitter(
179177
feedbackService,
@@ -184,7 +182,6 @@ class NetworkModule {
184182
appCoroutineScope,
185183
appBuildConfig,
186184
dispatcherProvider,
187-
onboardingDesignExperimentManager,
188185
)
189186

190187
companion object {

app/src/main/java/com/duckduckgo/app/feedback/api/FeedbackSubmitter.kt

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ import com.duckduckgo.app.feedback.ui.negative.FeedbackType.MainReason.OTHER
2525
import com.duckduckgo.app.feedback.ui.negative.FeedbackType.MainReason.SEARCH_NOT_GOOD_ENOUGH
2626
import com.duckduckgo.app.feedback.ui.negative.FeedbackType.MainReason.WEBSITES_NOT_LOADING
2727
import com.duckduckgo.app.feedback.ui.negative.FeedbackType.SubReason
28-
import com.duckduckgo.app.onboardingdesignexperiment.OnboardingDesignExperimentManager
2928
import com.duckduckgo.app.pixels.AppPixelName
3029
import com.duckduckgo.app.pixels.AppPixelName.FEEDBACK_NEGATIVE_SUBMISSION
3130
import com.duckduckgo.app.statistics.pixels.Pixel
@@ -66,7 +65,6 @@ class FireAndForgetFeedbackSubmitter(
6665
private val appCoroutineScope: CoroutineScope,
6766
private val appBuildConfig: AppBuildConfig,
6867
private val dispatcherProvider: DispatcherProvider,
69-
private val onboardingDesignExperimentManager: OnboardingDesignExperimentManager,
7068
) : FeedbackSubmitter {
7169
override suspend fun sendNegativeFeedback(
7270
mainReason: MainReason,
@@ -150,13 +148,6 @@ class FireAndForgetFeedbackSubmitter(
150148
url: String? = null,
151149
reason: String = FeedbackService.REASON_GENERAL,
152150
) {
153-
// Delete after the experiment has finished and go back to always return atbWithVariant()
154-
val atb = if (onboardingDesignExperimentManager.isAnyExperimentEnrolledAndEnabled()) {
155-
atbWithVariant() + "_${onboardingDesignExperimentManager.getCohort()}"
156-
} else {
157-
atbWithVariant()
158-
}
159-
160151
feedbackService.submitFeedback(
161152
reason = reason,
162153
category = category,
@@ -168,7 +159,7 @@ class FireAndForgetFeedbackSubmitter(
168159
manufacturer = Build.MANUFACTURER,
169160
model = Build.MODEL,
170161
api = appBuildConfig.sdkInt,
171-
atb = atb,
162+
atb = atbWithVariant(),
172163
)
173164
}
174165

0 commit comments

Comments
 (0)