Skip to content

Commit 53b64f0

Browse files
authored
Implement favorites on Android (#1236)
* - Modify database to store favorites - Create entity - Create DAO * Allow users to add a favorite * show favorite confirmation message when added * Add empty case hint as part of recycler view. * - Extracted adapters out from BookmarkActivity class - Added logic to display empty hint in favorites adapter - Updated new UI elements to be displayed correctly and with expected copy * changed bookmark dialog copies to be generic * Refactor: introduced savedSite as sealed class to model bookmarks and favorites - be able to reuse dialog - be able to reuse command logic - be able to reuse same listeners - decouple from entity data objects from databases in UI * Show favorites as quick access items in SystemSearchActivity * centering items in recyclerview * drag-drop in System search activity * show/hide context menu depending on user interactions: - if user moves the item, hide menu * edit/delete quickaccess items in SystemSearchActivity screen * show quickAccess items in BrowserTabFragment * browseractivity quick access items interactions * New placeholder for favicons implemented as extension function * calculate grid view items and margins so they appear centered * integrate favorites in autocomplete * scale favorite for drag and drop * improve drag-drop UX * Favicon manager refactor: - handle apple touch events - store them in persited store - naming refactor * favicon manager refactor to reduce logic outside favicon manager to decide the data source to use (temp or persist) * Skip http request for favicons when user browsing in the same site * show favorites when omnibar focused * Fix 3 dots clickable are in for favorite/boomark items * Quick access grid show title in 2 lines
1 parent 5596ef1 commit 53b64f0

File tree

68 files changed

+3936
-615
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

68 files changed

+3936
-615
lines changed

app/build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,7 @@ dependencies {
141141
implementation AndroidX.appCompat
142142
implementation Google.android.material
143143
implementation AndroidX.constraintLayout
144+
implementation AndroidX.recyclerView
144145
implementation AndroidX.swipeRefreshLayout
145146
implementation AndroidX.webkit
146147
implementation Square.okHttp3.okHttp

0 commit comments

Comments
 (0)