Remove possibility of not checking for https because data not yet loaded

Author: subsymbolic

app/src/main/java/com/duckduckgo/app/httpsupgrade/HttpsUpgrader.kt

@@ -22,7 +22,6 @@ import com.duckduckgo.app.global.UrlScheme
 import com.duckduckgo.app.global.isHttps
 import com.duckduckgo.app.httpsupgrade.api.HttpsBloomFilterFactory
 import com.duckduckgo.app.httpsupgrade.db.HttpsWhitelistDao
-import io.reactivex.schedulers.Schedulers
 import timber.log.Timber
 
 interface HttpsUpgrader {
@@ -43,10 +42,8 @@ class HttpsUpgraderImpl(
 ) : HttpsUpgrader {
 
     private var httpsBloomFilter: BloomFilter? = null
+    private var dataLoaded = false
 
-    init {
-        reloadData()
-    }
 
     @WorkerThread
     override fun shouldUpgrade(uri: Uri): Boolean {
@@ -55,6 +52,10 @@ class HttpsUpgraderImpl(
             return false
         }
 
+        if (!dataLoaded) {
+            reloadData()
+        }
+
         val host = uri.host
         if (whitelistedDao.contains(host)) {
             Timber.d("${host} is in whitelist and so not upgradable")
@@ -75,9 +76,8 @@ class HttpsUpgraderImpl(
     }
 
     override fun reloadData() {
-        Schedulers.io().scheduleDirect {
-            httpsBloomFilter = bloomFactory.create()
-        }
+        dataLoaded = true
+        httpsBloomFilter = bloomFactory.create()
     }
 
     companion object {