Fix threading

Author: CrisBarreiro

app/src/main/java/com/duckduckgo/app/browser/RealDuckDuckGoWebView.kt

@@ -482,7 +482,7 @@ class RealDuckDuckGoWebView : DuckDuckGoWebView, NestedScrollingChild3 {
     @SuppressLint("RequiresFeature")
     override suspend fun safePostMessage(
         replyProxy: JavaScriptReplyProxy,
-        response: JSONObject
+        response: JSONObject,
     ) {
         runCatching {
             if (webViewCapabilityChecker.isSupported(WebViewCapability.WebMessageListener)) {

browser-api/src/main/java/com/duckduckgo/app/browser/api/DuckDuckGoWebView.kt

@@ -61,6 +61,6 @@ abstract class DuckDuckGoWebView(
 
     abstract suspend fun safePostMessage(
         replyProxy: JavaScriptReplyProxy,
-        response: JSONObject
+        response: JSONObject,
     )
 }

content-scope-scripts/content-scope-scripts-impl/src/main/java/com/duckduckgo/contentscopescripts/impl/messaging/AdsjsContentScopeMessaging.kt

@@ -20,6 +20,7 @@ import android.webkit.WebView
 import androidx.annotation.VisibleForTesting
 import androidx.webkit.JavaScriptReplyProxy
 import com.duckduckgo.app.browser.api.DuckDuckGoWebView
+import com.duckduckgo.app.di.AppCoroutineScope
 import com.duckduckgo.common.utils.DispatcherProvider
 import com.duckduckgo.common.utils.plugins.PluginPoint
 import com.duckduckgo.contentscopescripts.api.AdsjsContentScopeJsMessageHandlersPlugin
@@ -34,6 +35,8 @@ import com.squareup.anvil.annotations.ContributesBinding
 import com.squareup.moshi.Moshi
 import javax.inject.Inject
 import javax.inject.Named
+import kotlinx.coroutines.CoroutineScope
+import kotlinx.coroutines.launch
 import kotlinx.coroutines.withContext
 import logcat.LogPriority.ERROR
 import logcat.asLog
@@ -49,6 +52,7 @@ class AdsjsContentScopeMessaging @Inject constructor(
     private val globalHandlers: PluginPoint<GlobalContentScopeJsMessageHandlersPlugin>,
     private val adsJsContentScopeScripts: AdsJsContentScopeScripts,
     private val dispatcherProvider: DispatcherProvider,
+    @AppCoroutineScope private val appCoroutineScope: CoroutineScope,
 ) : AdsjsMessaging {
 
     private val moshi = Moshi.Builder().add(JSONObjectAdapter()).build()
@@ -115,7 +119,7 @@ class AdsjsContentScopeMessaging @Inject constructor(
                     process(
                         message.data ?: "",
                         jsMessageCallback,
-                        replyProxy
+                        replyProxy,
                     )
                 }
             } ?: false
@@ -139,18 +143,20 @@ class AdsjsContentScopeMessaging @Inject constructor(
         }
     }
 
-    private suspend fun onResponse(response: JsCallbackData, replyProxy: JavaScriptReplyProxy) {
+    private fun onResponse(response: JsCallbackData, replyProxy: JavaScriptReplyProxy) {
         runCatching {
             val responseWithId = JSONObject().apply {
                 put("id", response.id)
                 put("result", response.params)
                 put("featureName", response.featureName)
                 put("context", context)
             }
-            (webView as? DuckDuckGoWebView)?.safePostMessage(
-                replyProxy,
-                responseWithId,
-            )
+            appCoroutineScope.launch(dispatcherProvider.main()) {
+                (webView as? DuckDuckGoWebView)?.safePostMessage(
+                    replyProxy,
+                    responseWithId,
+                )
+            }
         }
     }
 }

js-messaging/js-messaging-api/src/main/java/com/duckduckgo/js/messaging/api/AdsjsMessaging.kt

@@ -58,7 +58,7 @@ interface AdsjsMessageHandler {
     fun process(
         jsMessage: JsMessage,
         jsMessageCallback: AdsjsJsMessageCallback?,
-        onResponse: suspend (JSONObject) -> Unit,
+        onResponse: (JSONObject) -> Unit,
     )
 
     /**